fix: filter own messages in wait pre-poll path - #3
Merged
Conversation
The immediate-delivery check (pre-poll) didn't apply sender filtering, so `wait --for zeke` would wake on zeke's own unread messages. Now applies the same sender check as the poll loop. When only own messages are unread, advances cursor past them and falls through to polling.
baby-joel
approved these changes
Mar 10, 2026
baby-joel
left a comment
baby-joel
left a comment
Contributor
There was a problem hiding this comment.
Clean fix — the pre-poll path was missing sender filtering. Logic mirrors the poll loop correctly, and advancing cursor past own messages before entering the loop is the right call. Approved! 🤝
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wait --for zekewould wake on zeke's own unread messagesHotfix for a gap introduced when merging PRs #1 and #2 — the pre-poll path from #2 didn't incorporate the sender filtering from #1.
Test plan
wait --for zekewith only own unread messages → skips them, enters poll loop, times outwait --for zekewith other sender's message unread → wakes immediatelywaitwithout--for→ wakes on any message (no filtering)🌀 Magic applied with Wibey CLI 🪄 (https://wibey.walmart.com/cli)