Skip to content

[Club] Contact page #124

Merged
Arthur1asdf merged 46 commits into
KnightHacks:mainfrom
Arthur1asdf:main
May 16, 2025
Merged

[Club] Contact page #124
Arthur1asdf merged 46 commits into
KnightHacks:mainfrom
Arthur1asdf:main

Conversation

@Arthur1asdf
Copy link
Copy Markdown
Contributor

Why

Baby's first pr

What

Contact form for the club site from the figma's design

Test Plan

Lots of inspect element
https://imgur.com/a/oxIqMLC

@Arthur1asdf Arthur1asdf self-assigned this May 13, 2025
Copy link
Copy Markdown
Contributor

@Lewin-B Lewin-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Arthur1asdf Arthur1asdf added this pull request to the merge queue May 15, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch May 15, 2025
@Arthur1asdf Arthur1asdf added this pull request to the merge queue May 15, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch May 15, 2025
@Arthur1asdf
Copy link
Copy Markdown
Contributor Author

that's odd I will take a look into it when I get home from campus

@Arthur1asdf Arthur1asdf added this pull request to the merge queue May 16, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch May 16, 2025
@Arthur1asdf Arthur1asdf added this pull request to the merge queue May 16, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch May 16, 2025
…r design, did not make it link to anything or do anything yet
…st added lorem ipsum, left nav bar might be changed to just nav bar icons, not sure yet
… of the page with my resume linkedin and personal website
…pscare and audio, contact takes to google maps, github takes to my github, linkedin takes to my linkedin, resume takes to my resume, website takes to my personal website, Mercari gives a beggin screen and another link before taking you to my mecari
…tsx into the page.tsx, so everything that is inside page will be dead center. sample.tsx file is changed into header.tsx. Deleted the placeholder png file inside assets and added svg react components using svgs from figma.
…e contact form, added some css changes to the contact form: border radius for inputs and form, letter spacing for the labels, and font changes to words inside the input
…t so contact form would scroll up and cover the header
… to have a glowing effect. Flickering not finished, just need to tweak numbers around and commented out flickerStart
…sword and abstract shape component because I figured instead of goo goo gaa gaa translate-x and y and then margin left and right later, why don't I just crop the white space in SVG component file itself and do left-0? WOW, that's so smart Arthur! Why, thank you, Arthur. I think I'm done for today, I shall go open more prismatic evolution packs, I wonder if the 36th pack will finally give me a hit?
…n tablets; tablet designs are completely finished
…ens, also added mb to certain heights of screens
…after fetching from upstream. I'm trying to figure out why I am getting a 'This branch cannot be rebased due to conflicts' error
@Arthur1asdf Arthur1asdf reopened this May 16, 2025
@Arthur1asdf Arthur1asdf requested a review from a team as a code owner May 16, 2025 03:46
Fixing error with 'This branch cannot be rebased due to conflicts'
@Arthur1asdf Arthur1asdf added this pull request to the merge queue May 16, 2025
Merged via the queue into KnightHacks:main with commit 3c37b86 May 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants