Update pnpm-lock and install missing dependencies#323
Update pnpm-lock and install missing dependencies#323DGoel1602 merged 10 commits intoKnightHacks:mainfrom
Conversation
Update package.json and pnpm-lock. Not sure if there are cascading issues. There might be. Note that `api/src/form.tsx` has a type mismatch error. Not sure why? Me neither.
See prev commit. Not sure why I have to do this. Seems to work...?
| @@ -1,8 +1,8 @@ | |||
| import { fileURLToPath } from "url"; | |||
| import { createJiti } from "jiti"; | |||
| import createJiti from 'jiti'; | |||
There was a problem hiding this comment.
I want to note that I have no idea why this and the next change has to be done.
There was a problem hiding this comment.
jiti library likely made createJiti a default export and changed some params, lgtm here
| }, | ||
| "prettier": "@forge/prettier-config" | ||
| "prettier": "@forge/prettier-config", | ||
| "dependencies": { |
There was a problem hiding this comment.
This is probably not needed can I have someone test this.
There was a problem hiding this comment.
pnpm i minimatch did that lmfao
error TS2688: Cannot find type definition file for 'minimatch'.
The file is in the program because:
Entry point for implicit type library 'minimatch'
Thats the error we get without it even though we have types installed cause ts is buns
DVidal1205
left a comment
DVidal1205
left a comment
There was a problem hiding this comment.
looks fine. will get u write access eventually so u dont need to pr from fork
|
Build is failing for me. Might want to look into this @DGoel1602 |
|
Dhruv confirms build fails. LBTM |
4 participants
Why
Some version mismatches were causing some issues for Dhruv and I.
What
Test Plan
pnpm devbuilds with 1 issue. See initial commit for more info.