Skip to content

[#362] Member Search Mobile Forced Refresh#371

Merged
DVidal1205 merged 3 commits intomainfrom
blade/mobile-members-force-refresh
Feb 17, 2026
Merged

[#362] Member Search Mobile Forced Refresh#371
DVidal1205 merged 3 commits intomainfrom
blade/mobile-members-force-refresh

Conversation

@jesusthecreator017
Copy link
Contributor

@jesusthecreator017 jesusthecreator017 commented Feb 16, 2026

Why

There was major mobile layout issues with the new members page since I added pagination, and a bug where a mobile user when searching for a member if they did not type fast enough before the debounce time it would force refresh the page for them making searching basically impossible. This aims to fix those issues!

What

Issue(s): #362

Added layout changes for smaller devices: Selectors, Search bar, Pagination
Instead of showing a single div for the whole page when the data was loading, only show a "loading ... " status in the table so that the search bar doesn't "poof" out of reality kicking mobile users off of the search bar.
Added a first render check to see if a person loads directly into a page that is not 1 ("for whatever reason") so that they aren't automatically kicked back into the first page causing an autorefresh.

Test Plan

Using chrome dev tools to test the mobile formatting, and praying that the mobile keyboard works now.

Images

Screenshot 2026-02-15 at 10 24 22 PM

Checklist

  • Database: No schema changes, OR I have contacted the Development Lead to run db:push before merging
  • Environment Variables: No environment variables changed, OR I have contacted the Development Lead to modify them on Coolify BEFORE merging.

Summary by CodeRabbit

  • UI Improvements

    • Pagination labels now hide on extra-small screens for a cleaner mobile interface.
    • Enhanced responsive layout for member management controls on smaller screens.
  • Bug Fixes

    • Search functionality now properly resets pagination to avoid unnecessary navigation.
    • Improved loading and error state displays in member tables for better user feedback.

Hopefully fixed the mobile force refresh issue when searching
@jesusthecreator017 jesusthecreator017 self-assigned this Feb 16, 2026
@jesusthecreator017 jesusthecreator017 added Bug Something isn't working Minor Small change - 1 reviewer required Blade Change modifies code in Blade app labels Feb 16, 2026
@coderabbitai
Copy link

coderabbitai bot commented Feb 16, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

This PR updates UI responsiveness in the pagination component and refactors the members table with improved state management, adjusted debounce timing (250ms → 500ms), and better loading/error state handling through triage rendering.

Changes

Cohort / File(s) Summary
Pagination Responsiveness
packages/ui/src/pagination.tsx
Wrapped "Previous" and "Next" text labels in spans with hidden sm:inline class to hide labels on extra-small screens while maintaining icon visibility.
Members Table Refactoring
apps/blade/src/app/_components/admin/club/members/members-table.tsx
Added stable refs and render tracking to prevent unnecessary state updates; increased debounce timeout to 500ms; implemented triage rendering pattern for loading/error states; simplified search onChange handler and restructured layout for responsive behavior.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested labels

UI

Suggested reviewers

  • DVidal1205
  • DVidal1205-Crest
🚥 Pre-merge checks | ✅ 6 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (6 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title follows the required format with issue number in brackets and clearly describes the main changes addressing mobile layout issues and search debounce problems.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main
No Hardcoded Secrets ✅ Passed Examined pagination.tsx and members-table.tsx for hardcoded secrets, API keys, passwords, and tokens. No sensitive credentials found in either file.
Validated Env Access ✅ Passed Neither modified file uses direct process.env access; both follow codebase conventions by relying on proper imports for environmental configuration.
No Typescript Escape Hatches ✅ Passed Both modified files pass the TypeScript escape hatch check with zero instances of any type declarations, @ts-ignore/@ts-expect-error comments, and non-null assertions.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch blade/mobile-members-force-refresh

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@DVidal1205 DVidal1205 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sensational

@DVidal1205 DVidal1205 added this pull request to the merge queue Feb 17, 2026
Merged via the queue into main with commit de31e1e Feb 17, 2026
8 checks passed
@DVidal1205 DVidal1205 deleted the blade/mobile-members-force-refresh branch February 17, 2026 03:53
@coderabbitai coderabbitai bot mentioned this pull request Feb 18, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Blade Change modifies code in Blade app Bug Something isn't working Minor Small change - 1 reviewer required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants