Skip to content

Feat: Schedule Activity#298

Merged
JayDwee merged 8 commits intomasterfrom
feature/shedule-activity
Apr 12, 2022
Merged

Feat: Schedule Activity#298
JayDwee merged 8 commits intomasterfrom
feature/shedule-activity

Conversation

@JayDwee
Copy link
Copy Markdown
Member

@JayDwee JayDwee commented Apr 12, 2022

Summary

Scheduled activities can be set up with k!activity set which can be used for scheduling NUEL final streams

Checklist

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

  • Have you tested the changes? (pytest & dpytest)
  • Have you followed PEP-8 for naming and styling?
  • Has your code been properly documented with RestructuredText docstrings?
  • Have you added your changes to CHANGELOG.md under the [Unreleased] heading?
  • If your code added new bot commands, have you updated documentation.json?

  • All of this code is your own, or follows the author repo's licence.

@JayDwee JayDwee self-assigned this Apr 12, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 12, 2022

Codecov Report

Merging #298 (0d458aa) into master (c2baf89) will increase coverage by 0.29%.
The diff coverage is 96.81%.

@@            Coverage Diff             @@
##           master     #298      +/-   ##
==========================================
+ Coverage   85.34%   85.64%   +0.29%     
==========================================
  Files         101      107       +6     
  Lines        7302     7488     +186     
==========================================
+ Hits         6232     6413     +181     
- Misses       1070     1075       +5     
Flag Coverage Δ
unittests 85.64% <96.81%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
koalabot.py 75.00% <50.00%> (-0.52%) ⬇️
koala/cogs/base/models.py 93.75% <93.75%> (ø)
koala/cogs/base/cog.py 92.36% <96.22%> (+1.56%) ⬆️
koala/cogs/base/core.py 97.29% <97.29%> (ø)
koala/cogs/base/db.py 100.00% <100.00%> (ø)
koala/cogs/base/utils.py 93.33% <100.00%> (-1.91%) ⬇️
koala/db.py 98.91% <100.00%> (+0.13%) ⬆️
tests/cogs/base/conftest.py 100.00% <100.00%> (ø)
tests/cogs/base/test_cog.py 100.00% <100.00%> (ø)
tests/cogs/base/test_core.py 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2baf89...0d458aa. Read the comment docs.

@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Apr 12, 2022

This pull request introduces 2 alerts when merging ab64921 into c2baf89 - view on LGTM.com

new alerts:

  • 1 for Unused import
  • 1 for Module is imported with 'import' and 'import from'

@JayDwee
Copy link
Copy Markdown
Member Author

JayDwee commented Apr 12, 2022

merging without review due to fast track

@JayDwee JayDwee merged commit 84c0dc1 into master Apr 12, 2022
Copy link
Copy Markdown
Contributor

@stefan-cooper stefan-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :D

@JayDwee JayDwee deleted the feature/shedule-activity branch May 2, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants