Implement new array types for HL#1392
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the new array types in HL and fixes compilation.
I'm not particularly happy with the now missing
setData()function that existed in the HL backend. I had to remove/replace it because the typed arrays no longer have their own Haxe sources in the backend, should I reimplement this function forByteArraywith the byte length instead of the number of typed elements as a parameter?Also, does anyone know if it is possible in HL to set a finalizer like you can do it for hxcpp? This could make calls like
(cast myTypedArray: ByteArray).free()obsolete.