Skip to content

Fixed compilation issue with fmt > 11 - #468

Merged
axsaucedo merged 1 commit into
KomputeProject:masterfrom
planar-project:fix-fmt-format
Jul 26, 2026
Merged

Fixed compilation issue with fmt > 11#468
axsaucedo merged 1 commit into
KomputeProject:masterfrom
planar-project:fix-fmt-format

Conversation

@hamdannawaz582

Copy link
Copy Markdown
Contributor

fmt has deprecated using fmt::format by including fmt/core.h (see this file, this results in Kompute not compiling as a vcpkg project when its flags are set to KOMPUTE_OPT_USE_BUILT_IN_FMT=OFF as vcpkg defaults to version 12.2.

This PR fixes this issue by including fmt/format.h in the 2 files where fmt::format is used directly.

Confirmed to compile on linux both as a vcpkg project and via the standalone dependency resolution which still uses fmt 11.

@hamdannawaz582

Copy link
Copy Markdown
Contributor Author

P.S. the steps suggested by the DCO bot don't work as I do not have permission to push to the repo

git push --force-with-lease origin fix-fmt-format
remote: Permission to KomputeProject/kompute.git denied to hamdannawaz582.
fatal: unable to access 'https://github.com/KomputeProject/kompute.git/': The requested URL returned error: 403

@axsaucedo

Copy link
Copy Markdown
Member

@hamdannawaz582 you need to push to your own branch planar-project:fix-fmt-format

…rmat

Signed-off-by: Hamdan Nawaz <hamdannawaz582@gmail.com>
@axsaucedo

Copy link
Copy Markdown
Member

Looks good - thank you!

@axsaucedo
axsaucedo merged commit 890c97e into KomputeProject:master Jul 26, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants