fix(security): upgrade deck to Go 1.25.9#1997
Conversation
|
|
There was a problem hiding this comment.
Pull request overview
Updates the project’s Go toolchain version to address reachable Go standard library vulnerabilities reported by govulncheck, aligning both module configuration and container build tooling.
Changes:
- Bump
go.modGo version from1.25.7to1.25.9. - Update the Docker build stage to use
golang:1.25.9with a pinned image digest.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
go.mod |
Updates the declared Go version to the patched release. |
Dockerfile |
Updates the Go builder image version/digest used for container builds. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ARG GO_VERSION=1.25.9@sha256:7a00384194cf2cb68924bbb918d675f1517357433c8541bac0ab2f929b9d5447 | ||
| FROM golang:${GO_VERSION} AS build |
There was a problem hiding this comment.
GO_VERSION is used as a build-arg in the release workflow (it passes only the version extracted from go.mod). That overrides this default tag@digest value, so CI/release builds will end up using an unpinned golang:1.25.9 base and the digest pinning here won’t actually take effect for published images. Consider either (a) passing tag@digest from the workflow, (b) splitting version and digest into separate args (or hardcoding digest in FROM), or (c) removing the workflow override if you want Dockerfile-controlled pinning.
| ARG GO_VERSION=1.25.9@sha256:7a00384194cf2cb68924bbb918d675f1517357433c8541bac0ab2f929b9d5447 | |
| FROM golang:${GO_VERSION} AS build | |
| ARG GO_VERSION=1.25.9 | |
| ARG GO_IMAGE_DIGEST=sha256:7a00384194cf2cb68924bbb918d675f1517357433c8541bac0ab2f929b9d5447 | |
| FROM golang:${GO_VERSION}@${GO_IMAGE_DIGEST} AS build |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1997 +/- ##
==========================================
- Coverage 32.92% 32.88% -0.05%
==========================================
Files 77 77
Lines 6988 6988
==========================================
- Hits 2301 2298 -3
- Misses 4504 4506 +2
- Partials 183 184 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- bump go.mod from 1.25.7 to 1.25.9 - pin the Docker builder image to the matching Go 1.25.9 digest - resolves stdlib vulnerabilities in crypto/x509, crypto/tls, and net/url
628e7c8 to
f33a08b
Compare
Addresses the Go stdlib vulnerabilities confirmed on
origin/mainand release tagv1.57.3when scanned withGOTOOLCHAIN=go1.25.7.Changes:
go.modfromgo 1.25.7togo 1.25.9Dockerfilebuilder image togolang:1.25.9with the matching pinned digestValidation:
GOTOOLCHAIN=go1.25.7 govulncheck ./...onorigin/mainandv1.57.3reports 4 reachable stdlib vulnerabilities1.25.9imageRelated issue: #1996
cc @Kong/team-deck