Skip to content

fix(security): upgrade deck to Go 1.25.9#1997

Merged
Prashansa-K merged 1 commit intoKong:mainfrom
bhatikuldeep:fix/go-1.25.9-stdlib-vulns
Apr 10, 2026
Merged

fix(security): upgrade deck to Go 1.25.9#1997
Prashansa-K merged 1 commit intoKong:mainfrom
bhatikuldeep:fix/go-1.25.9-stdlib-vulns

Conversation

@bhatikuldeep
Copy link
Copy Markdown
Member

Addresses the Go stdlib vulnerabilities confirmed on origin/main and release tag v1.57.3 when scanned with GOTOOLCHAIN=go1.25.7.

Changes:

  • bump go.mod from go 1.25.7 to go 1.25.9
  • update Dockerfile builder image to golang:1.25.9 with the matching pinned digest

Validation:

  • GOTOOLCHAIN=go1.25.7 govulncheck ./... on origin/main and v1.57.3 reports 4 reachable stdlib vulnerabilities
  • patched branch removes the reachable findings
  • local Docker build succeeds with the pinned 1.25.9 image

Related issue: #1996

cc @Kong/team-deck

Copilot AI review requested due to automatic review settings April 10, 2026 12:18
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the project’s Go toolchain version to address reachable Go standard library vulnerabilities reported by govulncheck, aligning both module configuration and container build tooling.

Changes:

  • Bump go.mod Go version from 1.25.7 to 1.25.9.
  • Update the Docker build stage to use golang:1.25.9 with a pinned image digest.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
go.mod Updates the declared Go version to the patched release.
Dockerfile Updates the Go builder image version/digest used for container builds.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Dockerfile
Comment on lines +1 to 2
ARG GO_VERSION=1.25.9@sha256:7a00384194cf2cb68924bbb918d675f1517357433c8541bac0ab2f929b9d5447
FROM golang:${GO_VERSION} AS build
Copy link

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GO_VERSION is used as a build-arg in the release workflow (it passes only the version extracted from go.mod). That overrides this default tag@digest value, so CI/release builds will end up using an unpinned golang:1.25.9 base and the digest pinning here won’t actually take effect for published images. Consider either (a) passing tag@digest from the workflow, (b) splitting version and digest into separate args (or hardcoding digest in FROM), or (c) removing the workflow override if you want Dockerfile-controlled pinning.

Suggested change
ARG GO_VERSION=1.25.9@sha256:7a00384194cf2cb68924bbb918d675f1517357433c8541bac0ab2f929b9d5447
FROM golang:${GO_VERSION} AS build
ARG GO_VERSION=1.25.9
ARG GO_IMAGE_DIGEST=sha256:7a00384194cf2cb68924bbb918d675f1517357433c8541bac0ab2f929b9d5447
FROM golang:${GO_VERSION}@${GO_IMAGE_DIGEST} AS build

Copilot uses AI. Check for mistakes.
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 32.88%. Comparing base (c07059f) to head (f33a08b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1997      +/-   ##
==========================================
- Coverage   32.92%   32.88%   -0.05%     
==========================================
  Files          77       77              
  Lines        6988     6988              
==========================================
- Hits         2301     2298       -3     
- Misses       4504     4506       +2     
- Partials      183      184       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- bump go.mod from 1.25.7 to 1.25.9
- pin the Docker builder image to the matching Go 1.25.9 digest
- resolves stdlib vulnerabilities in crypto/x509, crypto/tls, and net/url
@bhatikuldeep bhatikuldeep force-pushed the fix/go-1.25.9-stdlib-vulns branch from 628e7c8 to f33a08b Compare April 10, 2026 12:25
@Prashansa-K Prashansa-K added skip-konnect Skip Konnect Integration tests in CI skip-ee Skip Enterprise Integration Tests in CI skip-oss Skip Open Source Integration Tests in CI labels Apr 10, 2026
@Prashansa-K Prashansa-K merged commit 3cdc72a into Kong:main Apr 10, 2026
19 of 47 checks passed
@bhatikuldeep bhatikuldeep deleted the fix/go-1.25.9-stdlib-vulns branch April 10, 2026 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-ee Skip Enterprise Integration Tests in CI skip-konnect Skip Konnect Integration tests in CI skip-oss Skip Open Source Integration Tests in CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants