Skip to content

fix(security): upgrade deck to Go 1.25.9 #1997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Prashansa-K merged 1 commit into from
Apr 10, 2026
+2 −2
Merged

fix(security): upgrade deck to Go 1.25.9 #1997

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG GO_VERSION=1.25.7@sha256:5a79b94c34c299ac0361fbb7c7fca6dc552e166b42341050323fa3ab137d7be9
ARG GO_VERSION=1.25.9@sha256:7a00384194cf2cb68924bbb918d675f1517357433c8541bac0ab2f929b9d5447
FROM golang:${GO_VERSION} AS build
Comment on lines +1 to 2
Copy link

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GO_VERSION is used as a build-arg in the release workflow (it passes only the version extracted from go.mod). That overrides this default tag@digest value, so CI/release builds will end up using an unpinned golang:1.25.9 base and the digest pinning here won’t actually take effect for published images. Consider either (a) passing tag@digest from the workflow, (b) splitting version and digest into separate args (or hardcoding digest in FROM), or (c) removing the workflow override if you want Dockerfile-controlled pinning.

Suggested change
ARG GO_VERSION=1.25.9@sha256:7a00384194cf2cb68924bbb918d675f1517357433c8541bac0ab2f929b9d5447
FROM golang:${GO_VERSION} AS build
ARG GO_VERSION=1.25.9
ARG GO_IMAGE_DIGEST=sha256:7a00384194cf2cb68924bbb918d675f1517357433c8541bac0ab2f929b9d5447
FROM golang:${GO_VERSION}@${GO_IMAGE_DIGEST} AS build

Copilot uses AI. Check for mistakes.
WORKDIR /deck
COPY go.mod ./
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/kong/deck

go 1.25.7
go 1.25.9

replace github.com/yudai/gojsondiff v1.0.0 => github.com/Kong/gojsondiff v1.3.0

Expand Down
Loading