feat(templating): (A1) route user-plugin actions through the sandbox

[jackkav]

A1 — Plugin actions via the sandbox

Fourth ticket of Phase 2. Routes user-plugin actions (request / requestGroup / workspace / document) through the QuickJS sandbox, mirroring the H1 hook path (PR 10a/10b). Gated on the existing templateTagSandboxEnabled flag.

What changes

• Sandbox core (marshal.ts, in-sandbox-bootstrap.ts, plugin-tag-sandbox.ts): the envelope gains actionKind/actionLabel/actionDomainData. __invokeAction() rebuilds the capability-gated context, resolves the kind-specific action list, finds the entry by label, and calls action(context, actionDomainData). Actions are fire-and-effect — they read the copied-in domain models and act only through the gated context.* bridge, so nothing is marshaled back. ACTION_RUNNER drives it; __invokeAction is added to the reviewed sandbox-internal global set + surface snapshot.
• Host (templating-worker-database.ts): runActionInSandbox() mirrors runRequestHookInSandbox (same bridge / grants / crypto). New protocol handler plugin.runUserAction resolves the plugin via resolveTrustedPlugin (registry-trusted directory + permissions — never caller-supplied) before dispatch.
• Plugin window (invoke-method.ts): executeAction routes user plugins (directory !== '') through plugin.runUserAction when the sandbox is on; bundle plugins and the flag-off path stay in-process. Actions are UI-triggered only, so there is no node-runtime / inso path to gate.

Scope notes

• Tag actions (templateTag.actions[]) are unchanged — the L1 manifest does not discover them, so they remain a flag-off surface (pre-existing).
• context.data is still not rebuilt in-sandbox (import/export actions that need it) — tracked follow-up, same as the hook PRs.

Tests

• Unit (sandbox-actions.test.ts): label match + domain-model passthrough, capability gating (ungranted context.network absent), missing-label error, kind-specific list resolution.
• E2E (sandbox-template-tags.test.ts + sandbox-action-collection.yaml): a request action writes a path canary (INSOMNIA_TEMPLATE_SANDBOX) + whether it received the domain models into plugin storage; a sibling tag reads it back. Flag off → runs in-process; flag on → the same action runs in the sandbox (its in-process fn is a throw-stub after discovery, so a successful write proves routing).

Validation

• type-check clean; eslint clean; full sandbox unit suite green (157). E2E runs in CI.

Stacked draft — part of the plugin-sandbox plan.

[github-actions]

✅ Circular References Report

Generated at: 2026-07-24T18:24:25.545Z
Status: ✅ NO CHANGE

Summary

Metric	Base (develop)	PR	Change
Total Circular References	9	9	0 (0.00%)

Click to view all circular references in PR (9)

insomnia-inso/src/db/models/types.ts -> insomnia-inso/src/db/types.ts
insomnia/src/main/prompt-bridge.ts -> insomnia/src/main/window-utils.ts -> insomnia/src/main/plugin-window.ts
insomnia/src/main/window-utils.ts -> insomnia/src/main/plugin-window.ts
insomnia/src/network/network.ts -> insomnia-scripting-environment/src/objects/index.ts -> insomnia-scripting-environment/src/objects/collection.ts -> insomnia-scripting-environment/src/objects/response.ts
insomnia/src/network/network.ts -> insomnia/src/common/render.ts
insomnia/src/ui/components/settings/import-export.tsx -> insomnia/src/ui/components/modals/export-requests-modal.tsx
insomnia/src/ui/components/tabs/tab-list.tsx -> insomnia/src/ui/components/tabs/tab.tsx
insomnia/src/ui/components/templating/tag-editor-arg-sub-form.tsx -> insomnia/src/ui/components/templating/external-vault/external-vault-form.tsx
insomnia/src/ui/components/viewers/response-viewer.tsx -> insomnia/src/ui/components/viewers/response-multipart-viewer.tsx

Click to view all circular references in base branch (9)

insomnia-inso/src/db/models/types.ts -> insomnia-inso/src/db/types.ts
insomnia/src/main/prompt-bridge.ts -> insomnia/src/main/window-utils.ts -> insomnia/src/main/plugin-window.ts
insomnia/src/main/window-utils.ts -> insomnia/src/main/plugin-window.ts
insomnia/src/network/network.ts -> insomnia-scripting-environment/src/objects/index.ts -> insomnia-scripting-environment/src/objects/collection.ts -> insomnia-scripting-environment/src/objects/response.ts
insomnia/src/network/network.ts -> insomnia/src/common/render.ts
insomnia/src/ui/components/settings/import-export.tsx -> insomnia/src/ui/components/modals/export-requests-modal.tsx
insomnia/src/ui/components/tabs/tab-list.tsx -> insomnia/src/ui/components/tabs/tab.tsx
insomnia/src/ui/components/templating/tag-editor-arg-sub-form.tsx -> insomnia/src/ui/components/templating/external-vault/external-vault-form.tsx
insomnia/src/ui/components/viewers/response-viewer.tsx -> insomnia/src/ui/components/viewers/response-multipart-viewer.tsx

Analysis

✅ No Change: This PR does not introduce or remove any circular references.

---

This report was generated automatically by comparing against the develop branch.

[Copilot]

Pull request overview

Adds a new sandbox execution path for user-plugin actions (request/requestGroup/workspace/document), routing them through the existing QuickJS templating sandbox when templateTagSandboxEnabled is enabled, and exposing a new host protocol endpoint to invoke these actions from the plugin window.

Changes:

• Extends the sandbox envelope and bootstrap to support __invokeAction() and an ACTION_RUNNER, selecting kind-specific action lists by label and executing actions as fire-and-effect (no marshaled return).
• Adds a main-process plugin.runUserAction templating-worker-database handler that resolves a trusted plugin install before dispatching runActionInSandbox().
• Updates the plugin-window executeAction path to route user plugins through the sandbox when the flag is enabled, while keeping bundle plugins and flag-off behavior in-process; adds unit + smoke coverage.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
packages/insomnia/src/templating/sandbox/sandbox-surface.ts	Adds __invokeAction to the sandbox-internal globals allowlist.
packages/insomnia/src/templating/sandbox/sandbox-actions.test.ts	New unit tests validating label matching, domain data passthrough, and capability gating for sandboxed actions.
packages/insomnia/src/templating/sandbox/plugin-tag-sandbox.ts	Selects the new ACTION_RUNNER when actionKind is present in the envelope.
packages/insomnia/src/templating/sandbox/marshal.ts	Extends ContextEnvelope with actionKind, actionLabel, and actionDomainData.
packages/insomnia/src/templating/sandbox/in-sandbox-bootstrap.ts	Implements globalThis.__invokeAction, locks it down, and adds ACTION_RUNNER.
packages/insomnia/src/templating/sandbox/snapshots/sandbox-surface.test.ts.snap	Updates sandbox surface snapshot to include __invokeAction.
packages/insomnia/src/plugins/invoke-method.ts	Routes user-plugin executeAction through plugin.runUserAction when sandbox is enabled.
packages/insomnia/src/main/templating-worker-database.ts	Adds runActionInSandbox() and registers plugin.runUserAction handler with trusted-plugin resolution.
packages/insomnia/src/common/templating/types.ts	Extends PluginToMainAPIPaths with plugin.runUserAction.
packages/insomnia-smoke-test/tests/smoke/sandbox-template-tags.test.ts	Adds E2E proving action routing switches between in-process vs sandbox via a storage canary.
packages/insomnia-smoke-test/fixtures/sandbox-action-collection.yaml	Adds a fixture collection used by the new E2E test.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.