fix: missing insomnia icon on Windows [#8092] - #8097
Merged
Conversation
filfreire
marked this pull request as ready for review
October 17, 2024 12:50
filfreire
changed the title
filfreire
changed the title
1 task
filfreire
force-pushed
the
fix/issue-windows-image
branch
from
October 17, 2024 12:55
792c149 to
e7e0109
Compare
ryan-willis
approved these changes
Oct 17, 2024
filfreire
enabled auto-merge (squash)
October 17, 2024 13:01
marckong
approved these changes
Oct 17, 2024
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8092
Cause for the issue - electron-builder's
signAndEditExecutableneeds to betrue- as it also adds metadata (and icon image) to the windows build. Initially set it to false under the impression it would optimize packaging by avoiding unnecessary download, but it can be safely kept to true if the customSign hook is set.Tested: