feat(declarative): expand external resource lookups - #2012
Merged
Conversation
rspurgeon
temporarily deployed
to
kongctl-acceptance
August 28, 2026 15:16 — with
GitHub Actions
Inactive
rspurgeon
had a problem deploying
to
kongctl-acceptance-4
August 28, 2026 15:16 — with
GitHub Actions
Failure
rspurgeon
had a problem deploying
to
kongctl-acceptance-2
August 28, 2026 15:51 — with
GitHub Actions
Failure
rspurgeon
temporarily deployed
to
kongctl-acceptance
August 28, 2026 15:51 — with
GitHub Actions
Inactive
rspurgeon
had a problem deploying
to
kongctl-acceptance-2
August 28, 2026 16:12 — with
GitHub Actions
Failure
rspurgeon
had a problem deploying
to
kongctl-acceptance-2
August 29, 2026 02:51 — with
GitHub Actions
Failure
Collaborator
Author
|
/ksai review |
rspurgeon
had a problem deploying
to
kongctl-acceptance-2
August 29, 2026 03:08 — with
GitHub Actions
Failure
Contributor
|
Run report (federated)
|
Contributor
There was a problem hiding this comment.
| Verdict | APPROVE_WITH_COMMENTS |
|---|---|
| Critical/High | 0 |
The change adds a generic external-lookup registry, relationship discriminators, and _external support for Catalog APIs and application auth strategies. The refactor is internally consistent and has good unit, integration, and E2E coverage. One Medium issue survived the audit pass: the new shared auth-strategy resolver depends on an index alignment that the UPDATE planner path does not guarantee.
Additional Risk pass over the non-Go files (docs, example YAML, E2E scenario and testdata) found no leaked secrets, no new attack surface, and no resource leaks.
rspurgeon
temporarily deployed
to
kongctl-acceptance
August 29, 2026 04:22 — with
GitHub Actions
Inactive
rspurgeon
had a problem deploying
to
kongctl-acceptance-4
August 29, 2026 04:22 — with
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
go fix ./...make formatmake buildmake testmake test-integrationdump/portal-ownedmake lintreports the existing 56 generated/mock-file findings (50 line-length, 4 spelling, and 2 staticcheck); this change introduces no lint findings.Closes #1674