fix(cmd): support control plane API implementation get - #2018
Merged
Conversation
rspurgeon
temporarily deployed
to
kongctl-acceptance
August 29, 2026 14:10 — with
GitHub Actions
Inactive
Collaborator
Author
|
/ksai review |
Contributor
|
Run report (federated)
|
Contributor
There was a problem hiding this comment.
| Verdict | Critical/High |
|---|---|
| REQUEST_CHANGES | 2 |
The diff adds a control-plane column to the API implementations view. The default compact table layout drops the new column, so the fix does not show in default output. A new e2e scenario asserts a JSON field name that the response type does not use, so the assertion fails every run. One test-coverage gap also survived. Additional Risk pass: no secrets, security, or resource-leak issues found in either the Go files or the e2e scenario file.
rspurgeon
temporarily deployed
to
kongctl-acceptance
August 30, 2026 14:42 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
go fix ./...make formatmake buildmake testgolangci-lint run ./internal/cmd/root/products/konnect/apimake lint(fails on pre-existing generated mock/portal-client line-length and misspelling findings, plus two pre-existing staticcheck findings)Closes #2006