Skip to content

fix(cmd): support control plane API implementation get - #2018

Merged
rspurgeon merged 2 commits into
mainfrom
fix/api-control-plane-implementation-get
Aug 30, 2026
Merged

fix(cmd): support control plane API implementation get#2018
rspurgeon merged 2 commits into
mainfrom
fix/api-control-plane-implementation-get

Conversation

@rspurgeon

Copy link
Copy Markdown
Collaborator

Summary

  • support control-plane implementation union values when filtering by implementation ID
  • populate control-plane implementation table rows and detail views
  • add unit coverage for control-plane formatting and both implementation variants
  • expand the E2E scenario with list, get-by-ID, and not-found coverage

Testing

  • go fix ./...
  • make format
  • make build
  • make test
  • golangci-lint run ./internal/cmd/root/products/konnect/api
  • make lint (fails on pre-existing generated mock/portal-client line-length and misspelling findings, plus two pre-existing staticcheck findings)

Closes #2006

@rspurgeon
rspurgeon requested review from a team as code owners August 29, 2026 13:15
@rspurgeon
rspurgeon temporarily deployed to kongctl-acceptance August 29, 2026 14:10 — with GitHub Actions Inactive
@rspurgeon
rspurgeon deployed to kongctl-acceptance-5 August 29, 2026 14:10 — with GitHub Actions Active
@rspurgeon
rspurgeon deployed to kongctl-acceptance-4 August 29, 2026 14:10 — with GitHub Actions Active
@rspurgeon
rspurgeon deployed to kongctl-acceptance-2 August 29, 2026 14:10 — with GitHub Actions Active
@rspurgeon
rspurgeon deployed to kongctl-acceptance-3 August 29, 2026 14:10 — with GitHub Actions Active
@rspurgeon

Copy link
Copy Markdown
Collaborator Author

/ksai review

@github-actions

Copy link
Copy Markdown
Contributor

Run report (federated)

Item Detail
Conclusion success
Reviewed commit b123ab36e955522c7b505bfeb8e5d3af61587ade
Model claude-sonnet-5 (effort high)
Arm source triage
Triage 4 files, 242 lines, risk false, api true, skills go-code-review,default-code-review
Triage reasons a moderate diff reads fine on sonnet
Plugin ref 7a653240672e97f9a61309a09d3617270ce34677
Prompt
Duration 699s (24 turns)
Input tokens (incl. cache) 1082444
Output tokens 17882
Permission denials 22
Total cost $4.6846
Classifier off — the comment named a verb, or no arm was usable

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict Critical/High
REQUEST_CHANGES 2

The diff adds a control-plane column to the API implementations view. The default compact table layout drops the new column, so the fix does not show in default output. A new e2e scenario asserts a JSON field name that the response type does not use, so the assertion fails every run. One test-coverage gap also survived. Additional Risk pass: no secrets, security, or resource-leak issues found in either the Go files or the e2e scenario file.

Comment thread internal/cmd/root/products/konnect/api/implementations.go Outdated
Comment thread test/e2e/scenarios/apis/control-plane-implementation/scenario.yaml
Comment thread internal/cmd/root/products/konnect/api/implementations_test.go
@rspurgeon
rspurgeon deployed to kongctl-acceptance-3 August 30, 2026 14:42 — with GitHub Actions Active
@rspurgeon
rspurgeon deployed to kongctl-acceptance-2 August 30, 2026 14:42 — with GitHub Actions Active
@rspurgeon
rspurgeon deployed to kongctl-acceptance-5 August 30, 2026 14:42 — with GitHub Actions Active
@rspurgeon
rspurgeon temporarily deployed to kongctl-acceptance August 30, 2026 14:42 — with GitHub Actions Inactive
@rspurgeon
rspurgeon deployed to kongctl-acceptance-4 August 30, 2026 14:42 — with GitHub Actions Active
@rspurgeon
rspurgeon merged commit df22ac7 into main Aug 30, 2026
28 checks passed
@rspurgeon
rspurgeon deleted the fix/api-control-plane-implementation-get branch August 30, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[e2e-scan] Test: Improve e2e coverage for get api implementations with control_plane type (expand scenario)

1 participant