feat: email domain lock config - #153
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds email-domain restrictions to declarative authentication configuration.
Changes:
- Supports domain allowlists and enforcement modes.
- Tests parsing, uploading, and clearing allowlists.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
internal/projectconfig/manifest.go |
Adds email-domain configuration fields. |
internal/projectconfig/manifest_email_domains_test.go |
Tests allowlist round-tripping and clearing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+133
to
+134
| AllowedEmailDomains *[]string `yaml:"allowed_email_domains,omitempty" json:"allowed_email_domains,omitempty"` | ||
| AllowedEmailDomainsMode *string `yaml:"allowed_email_domains_mode,omitempty" json:"allowed_email_domains_mode,omitempty"` |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goes in hand with the email domain lock work: https://github.com/Kong/volcano-hosting/pull/781