Skip to content

fix(cli): default all release builds to staging so the default install serves staging during testing - #92

Merged
tkkhq merged 1 commit into
mainfrom
tkim/staging-default-all-paths
Jul 25, 2026
Merged

fix(cli): default all release builds to staging so the default install serves staging during testing#92
tkkhq merged 1 commit into
mainfrom
tkim/staging-default-all-paths

Conversation

@tkkhq

@tkkhq tkkhq commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Tracking

Summary

  • default the CLI install to staging during the internal testing phase: production latest is not live yet, so the current default install is a broken production binary for new users
  • build every release path against staging in scripts/ci/resolve-cli-build-env.sh — stable tags (which become GitHub latest and npm @latest) now bake https://api.staging.volcano.dev + the staging device client id, not just main/nightly
  • keep it a deliberate, temporary swap: ponytail: comments mark the production blocks to restore before GA, and the production values are commented out so nothing bakes production during the phase
  • update the publish-cli.yml comment so it is clear the staging device client id is now consumed by all release paths

Follow-up actions (not code)

Verification

  • bash -n scripts/ci/resolve-cli-build-env.sh
  • python3 -c "import yaml; yaml.safe_load(open('.github/workflows/publish-cli.yml'))"
  • simulated resolve-cli-build-env.sh for a stable tag (v0.6.1 -> api.staging.volcano.dev, staging client id), for main (nightly -> staging), and with the staging repo variable unset (fails naming VOLCANO_FIRST_PARTY_DEVICE_CLIENT_ID_STAGING)

@tkkhq
tkkhq requested a review from a team as a code owner July 25, 2026 19:36
Copilot AI review requested due to automatic review settings July 25, 2026 19:36
@tkkhq
tkkhq enabled auto-merge (squash) July 25, 2026 19:37

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Defaults all CLI release builds to staging during internal testing, ensuring stable, nightly, npm, and downstream installs use the working staging environment.

Changes:

  • Bakes staging API, web URL, and OAuth client ID into every release path.
  • Updates workflow guidance for restoring production configuration before GA.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
scripts/ci/resolve-cli-build-env.sh Resolves stable and nightly builds to staging configuration.
.github/workflows/publish-cli.yml Clarifies staging client ID usage across releases.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tkkhq
tkkhq merged commit a2c3140 into main Jul 25, 2026
9 checks passed
@tkkhq
tkkhq deleted the tkim/staging-default-all-paths branch July 25, 2026 19:38
@kong-volcano-app kong-volcano-app Bot mentioned this pull request Jul 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants