fix(cli): default all release builds to staging so the default install serves staging during testing - #92
Merged
Merged
Conversation
…all staging during the testing phase
There was a problem hiding this comment.
Pull request overview
Defaults all CLI release builds to staging during internal testing, ensuring stable, nightly, npm, and downstream installs use the working staging environment.
Changes:
- Bakes staging API, web URL, and OAuth client ID into every release path.
- Updates workflow guidance for restoring production configuration before GA.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
scripts/ci/resolve-cli-build-env.sh |
Resolves stable and nightly builds to staging configuration. |
.github/workflows/publish-cli.yml |
Clarifies staging client ID usage across releases. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking
@stagingchannel, for GA when prod + staging coexist)Summary
latestis not live yet, so the current default install is a broken production binary for new usersscripts/ci/resolve-cli-build-env.sh— stable tags (which become GitHublatestand npm@latest) now bakehttps://api.staging.volcano.dev+ the staging device client id, not just main/nightlyponytail:comments mark the production blocks to restore before GA, and the production values are commented out so nothing bakes production during the phasepublish-cli.ymlcomment so it is clear the staging device client id is now consumed by all release pathsFollow-up actions (not code)
v0.6.1) so GitHublatest+ npm@latestflip to the staging buildKong/homebrew-volcanovolcano.rbformula to that release sobrew install Kong/volcano/volcanoserves staging too@stagingchannelVerification
bash -n scripts/ci/resolve-cli-build-env.shpython3 -c "import yaml; yaml.safe_load(open('.github/workflows/publish-cli.yml'))"resolve-cli-build-env.shfor a stable tag (v0.6.1->api.staging.volcano.dev, staging client id), formain(nightly -> staging), and with the staging repo variable unset (fails namingVOLCANO_FIRST_PARTY_DEVICE_CLIENT_ID_STAGING)