test(viewer): web_exports proptest surface (WBS-6.2 #437) - #449
Conversation
Adds `crates/sl-viewer/tests/properties_viewer_web_exports.rs` with
11 proptest properties pinning `WebExportProvider` and
`web_export_roots_with_env` reductions:
* `WebExportProvider::label`:
* Non-empty.
* Free of tabs / newlines / double-spaces (well-formed for badge UI).
* Distinct per variant (no accidental aliasing).
* `WebExportProvider::corpus`:
* Total — every variant maps to a `Corpus::ChatGptWeb | ClaudeWeb |
GeminiWeb` value (no panics, no fallback).
* Injective — distinct providers map to distinct corpora.
* `WebExportProvider::default_subdir`:
* Non-empty.
* Distinct per variant.
* Equals `label()` — `~/Downloads/<subdir>` lines up with the
user-facing provider name.
* `web_export_roots_with_env(home, None)`:
* Empty set when `home` is non-existent.
* Returns the subset of defaults whose `Downloads/<subdir>` path
exists on disk, exactly once each, in default order.
* Returns all three documented providers when all default dirs exist.
Updates WBS-6.2 evidence list, TRACEABILITY.json, and CHANGELOG.
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
Warning Review limit reached
Next review available in: 45 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
codeant-ai
Bot
added
the
size:L
![codeant-ai[bot]](https://avatars.githubusercontent.com/in/646884?s=60&v=4){kind=small}
| let existing_path = tmp.join("Downloads").join(provider.default_subdir()); | ||
| std::fs::create_dir_all(&existing_path).expect("mkdir provider"); | ||
|
|
||
| let roots = web_export_roots_with_env(&tmp, None); |
There was a problem hiding this comment.
Suggestion: The fixture only creates directories, so this property never exercises an existing regular file at a default root. The production discovery check accepts any existing filesystem entry, while the loader requires a readable directory; add a file fixture and assert that invalid roots are rejected or otherwise handled correctly. [incomplete implementation]
Severity Level: Major ⚠️
- ❌ File roots cause web-export loading errors.
- ⚠️ Default discovery accepts invalid directory entries.
- ⚠️ Current tests cover directories only.
(Use Cmd/Ctrl + Click for best experience)
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** crates/sl-viewer/tests/properties_viewer_web_exports.rs
**Line:** 173:176
**Comment:**
*Incomplete Implementation: The fixture only creates directories, so this property never exercises an existing regular file at a default root. The production discovery check accepts any existing filesystem entry, while the loader requires a readable directory; add a file fixture and assert that invalid roots are rejected or otherwise handled correctly.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
User description
Summary
Adds
crates/sl-viewer/tests/properties_viewer_web_exports.rswith 11 proptest properties pinning theWebExportProviderreductions andweb_export_roots_with_envdiscovery helper (WBS-6.2 #437).This branch has been rebased onto
origin/main(which now includes #433 timeline, #442 search/memory, #445 history_tab) after the operator closed the original PR for merge conflicts. Net-new file only; conflicts isolated to CHANGELOG.md / WBS.md / TRACEABILITY.json and resolved by keeping all entries.WebExportProvider::label(3) — non-empty, well-formed, distinct.WebExportProvider::corpus(2) — total over the three*WebCorpus variants; injective.WebExportProvider::default_subdir(3) — non-empty, distinct, equalslabel().web_export_roots_with_env(3) — empty for missing home; existing-default subset; all three when defaults exist.Validation
cargo test -p sl-viewer --test properties_viewer_web_exports --features "desktop parquet" --locked— 11 passedcargo fmt --all --check— cleanCodeAnt-AI Description
Add property coverage for viewer web-export discovery and provider mappings
What Changed
Impact
✅ Fewer web-export mapping regressions✅ Reliable discovery of existing export folders✅ Clearer coverage of supported web-export providers💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.