Skip to content

fix(ci): restore indexmap serde feature - #144

Merged
KooshaPari merged 1 commit into
mainfrom
fix/indexmap-serde-20260807
Aug 8, 2026
Merged

fix(ci): restore indexmap serde feature#144
KooshaPari merged 1 commit into
mainfrom
fix/indexmap-serde-20260807

Conversation

@KooshaPari

@KooshaPari KooshaPari commented Aug 7, 2026

Copy link
Copy Markdown
Owner

User description

The current main branch fails forge_ci compilation because IndexMap does not implement serde::Serialize without the serde feature. Restore the workspace dependency feature required by workflow_model derives.

Observed failures: runs 31218142671 and 31218142713.

Co-Authored-By: ForgeCode noreply@forgecode.dev


CodeAnt-AI Description

Restore CI compilation for serialized workflow data

What Changed

  • Re-enables serialization support for indexed maps used by workflow data
  • Restores successful compilation in CI and prevents serialization-related build failures

Impact

✅ Passing CI builds
✅ Reliable workflow data serialization

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

Copilot AI lite review requested due to automatic review settings August 7, 2026 23:18
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

@codeant-ai

codeant-ai Bot commented Aug 7, 2026

Copy link
Copy Markdown

🤖 CodeAnt AI — Review Status

Status Commit Started (UTC) Finished (UTC)
✅ Reviewed your PR 3c29020 Aug 07, 2026 · 23:18 23:19

@codeant-ai

codeant-ai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@codeant-ai codeant-ai Bot added the size:XS label Aug 7, 2026
@mergify mergify Bot added rust labels Aug 7, 2026
@kilo-code-bot

kilo-code-bot Bot commented Aug 7, 2026

Copy link
Copy Markdown

Code Review Summary

Status: No Issues Found | Recommendation: Merge

The one-line change at Cargo.toml:112 correctly restores the serde feature on the indexmap workspace dependency. This is required because crates/forge_ci/src/workflow_model.rs derives serde::Serialize on Workflow (line 7) and Permissions (line 174), both of which contain IndexMap fields (lines 15, 19, 174); without indexmap's serde feature, IndexMap does not implement Serialize and the crate fails to compile. The serde feature is the correct flag for indexmap 2.x, the version is unchanged (2.13.0), no new dependency is introduced (additive feature flag only), and forge_ci already consumes this via indexmap.workspace = true, so the workspace-level placement is idiomatic. Verified HEAD 3c29020 matches the PR head and confirmed no existing inline comments.

Files Reviewed (1 files)
  • Cargo.toml

Reviewed by laguna-s-2.1:free · Input: 155.5K · Output: 10.2K · Cached: 74.8K

@socket-security

Copy link
Copy Markdown

Dependency limit exceeded — report not shown.

This pull request scan exceeded the 10,000-dependency limit applied to this scan, so the results are incomplete and may be inaccurate. To avoid reporting false positives, Socket has not posted a report.

Upgrade your plan to raise the dependency limit and get complete reports, or view the partial scan in the dashboard.

Socket is always free for open source. If this is a non-commercial open source project, contact us to request a free Team account.

@KooshaPari
KooshaPari merged commit 9b59ad5 into main Aug 8, 2026
38 checks passed
@KooshaPari
KooshaPari deleted the fix/indexmap-serde-20260807 branch August 8, 2026 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants