Skip to content

fix(ci): resolve clippy::indexing_slicing + doctest compile errors - #210

Closed
KooshaPari wants to merge 1 commit into
mainfrom
fix/ci-indexing-doctest
Closed

fix(ci): resolve clippy::indexing_slicing + doctest compile errors#210
KooshaPari wants to merge 1 commit into
mainfrom
fix/ci-indexing-doctest

Conversation

@KooshaPari

@KooshaPari KooshaPari commented Aug 30, 2026

Copy link
Copy Markdown
Owner

User description

Summary


CodeAnt-AI Description

Prevent command and mention parsing failures while keeping examples buildable

What Changed

  • CLI parsing now reports errors instead of relying on unchecked argument positions
  • Webhook mention parsing safely ignores invalid text boundaries rather than risking a crash
  • The end-to-end testing example now matches the supported scenario-building workflow and compiles as documentation

Impact

✅ No crashes from malformed CLI or webhook input
✅ Clear errors for missing command arguments
✅ Buildable end-to-end testing documentation

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

Copilot AI lite review requested due to automatic review settings August 30, 2026 06:35
@codeant-ai

codeant-ai Bot commented Aug 30, 2026

Copy link
Copy Markdown

🤖 CodeAnt AI — Review Status

Status Commit Started (UTC) Finished (UTC)
✅ Reviewed your PR 819d293 Aug 30, 2026 · 06:35 06:36

@codeant-ai

codeant-ai Bot commented Aug 30, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@codeant-ai codeant-ai Bot added the size:S label Aug 30, 2026
@mergify mergify Bot added the rust label Aug 30, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 819d293c7a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +43 to +46
//! // The scenario is a script: the agent runtime reads it step by step.
//! let (steps, mock_llm) = scenario.into_mock_llm();
//! assert_eq!(steps.len(), 4); // 2 user_says + 2 expect_tool_call
//! assert_eq!(mock_llm.remaining(), 3); // 3 mock responses queued

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Replace the rustdoc example with concise prose

The newly added executable assertions extend a public Rust documentation code example, contrary to the repository's explicit requirement that documentation contain no code examples. Remove this block and describe the scenario/mock behavior in concise prose instead.

AGENTS.md reference: AGENTS.md:L117-L117

Useful? React with 👍 / 👎.

@KooshaPari

Copy link
Copy Markdown
Owner Author

Closing as superseded. PR #211 has a cleaner cli.rs refactor (split_first(), while-let Some(flag) pattern). Doctest fix handled locally and will land separately.

@KooshaPari KooshaPari closed this Aug 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants