Skip to content

fix(clippy): inspect parent wait errors - #221

Merged
KooshaPari merged 1 commit into
mainfrom
fix/forge-helper-inspect-err-20260901
Sep 1, 2026
Merged

fix(clippy): inspect parent wait errors#221
KooshaPari merged 1 commit into
mainfrom
fix/forge-helper-inspect-err-20260901

Conversation

@KooshaPari

@KooshaPari KooshaPari commented Sep 1, 2026

Copy link
Copy Markdown
Owner

User description

Summary

Fixes the Windows-only clippy::manual_inspect failure in helioslite_helper parent-process waiting. The previous map_err logged then returned the identical error code; inspect_err preserves that result while expressing the side effect directly.

Validation

  • RED: Windows hosted Clippy reported manual_inspect at helioslite_helper.rs:314 in PR #219 job.
  • cargo test --offline -p forge_main --bin helioslite_helper (4 passed)
  • cargo clippy --offline -p forge_main --bin helioslite_helper --all-targets -- -D warnings
  • cargo +nightly fmt --all -- --check
  • git diff --check

The local macOS host has no Windows Rust target, so hosted Windows CI is the remaining platform-specific confirmation.


CodeAnt-AI Description

Preserve parent-wait failures while reporting them clearly

What Changed

  • Parent-process wait failures still return the original error code after logging the diagnostic message
  • Windows Clippy checks no longer reject the helper's error handling

Impact

✅ Reliable parent-wait failure handling
✅ Clearer helper diagnostics
✅ Passing Windows Clippy checks

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

Co-Authored-By: ForgeCode <noreply@forgecode.dev>
Copilot AI lite review requested due to automatic review settings September 1, 2026 02:46

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@codeant-ai

codeant-ai Bot commented Sep 1, 2026

Copy link
Copy Markdown

🤖 CodeAnt AI — Review Status

Status Commit Started (UTC) Finished (UTC)
✅ Reviewed your PR 10928d0 Sep 01, 2026 · 02:47 02:50

@codeant-ai

codeant-ai Bot commented Sep 1, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@codeant-ai codeant-ai Bot added the size:XS label Sep 1, 2026
@mergify mergify Bot added the rust label Sep 1, 2026
@codeant-ai

codeant-ai Bot commented Sep 1, 2026

Copy link
Copy Markdown

CodeAnt Nitpicks

1 code suggestion

1. When waiting times out with code 7, this logs “not observed alive,” falsely describing the timeout and hiding the actual reason from diagnostics.

Incorrect log level · crates/forge_main/src/bin/helioslite_helper.rs:314

@kilo-code-bot

kilo-code-bot Bot commented Sep 1, 2026

Copy link
Copy Markdown

Code Review Summary

Status: No Issues Found | Recommendation: Merge

The diff replaces map_err(|code| { eprintln!(...); code }) with inspect_err(|&code| { eprintln!(...); }) at crates/forge_main/src/bin/helioslite_helper.rs:314. Semantically equivalent (the original u8 error code is still propagated unchanged), idiomatic, and resolves the Windows-only clippy::manual_inspect failure described in the PR body. The destructuring pattern |&code| correctly handles the u8 Err payload. No regressions in error propagation, logging, or control flow.

Files Reviewed (1 file)
  • crates/forge_main/src/bin/helioslite_helper.rs

Reviewed by free · Input: 22.9K · Output: 1.2K · Cached: 142K

@KooshaPari
KooshaPari merged commit 20e4ad1 into main Sep 1, 2026
36 of 40 checks passed
@KooshaPari
KooshaPari deleted the fix/forge-helper-inspect-err-20260901 branch September 1, 2026 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants