Skip to content

Conversation

@aSemy
Copy link
Contributor

@aSemy aSemy commented Mar 1, 2023

Minor QOL improvement in the Test DSL. Annotating the file paths with @Language("file-reference") means the files can be opened in IntelliJ by cmd+clicking the file path.

Missing files are highlighted.

image

Summary of changes

For this to work,

  • all paths need to be absolute from the root resources (all paths were already the full file path, I just needed to add the base /)
  • use java.getResouce() instead of classLoader.getResource().

Impact

This is a test-only change and does not have any impact on the library.

@aSemy aSemy marked this pull request as ready for review March 1, 2023 16:57
@qwwdfsad qwwdfsad changed the base branch from master to bcv-gradle-rework March 3, 2023 13:51
@qwwdfsad qwwdfsad self-requested a review March 3, 2023 13:51
Copy link
Member

@qwwdfsad qwwdfsad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! We definitely should leverage @Language more

@qwwdfsad qwwdfsad merged commit 9ca6f41 into Kotlin:bcv-gradle-rework Mar 3, 2023
@aSemy aSemy deleted the feat/language_tag_file_paths branch May 2, 2023 18:22
qwwdfsad added a commit that referenced this pull request Jan 12, 2024
* Annotate file paths with `@Language("file-reference")` (#126)
* Update to Gradle 8 (#122)
* bump Gradle Plugin Publish Plugin version
* build script updates & improvements
* use Java Toolchains to set the Java version
* use jvm-test-fixtures plugin for functionalTest sources
* update build config, remove redundant Maven publication

* Initial Gradle convention plugins (#123)
* Apply BCV, commit API dump (#131)
* The ABI shape will be reduced in the future, this is a technical change
* java-diff-utils
* Update Gradle to 8.5

---------

Co-authored-by: aSemy <897017+aSemy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants