Skip to content

Conversation

@aSemy
Copy link
Contributor

@aSemy aSemy commented Apr 27, 2023

Apply the BCV plugin.

I think we can all agree on why this is helpful :)

This PR depends on

@aSemy aSemy changed the title Apply BCV Apply BCV, commit API dump Apr 27, 2023
@aSemy aSemy changed the base branch from master to pr/122 April 27, 2023 08:44
@qwwdfsad qwwdfsad self-requested a review May 1, 2023 16:12
Copy link
Member

@qwwdfsad qwwdfsad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. Will merge after #123 and will sort out ABI eventually, seems like it has a bit too many signatures in public

aSemy added 5 commits May 1, 2023 18:53
- bump Gradle Plugin Publish Plugin version
- build script updates & improvements
- use Java Toolchains to set Java version
- use jvm-test-fixtures plugin for functionalTest sources
- create convention plugins for common and java-specific config
- add Gradle version catalog
- simplify some build config
@aSemy aSemy changed the base branch from pr/122 to bcv-gradle-rework May 1, 2023 17:11
@aSemy aSemy force-pushed the feat/apply_bcv branch from b24b6b7 to 223b410 Compare May 1, 2023 17:17
@aSemy
Copy link
Contributor Author

aSemy commented May 1, 2023

@qwwdfsad
Copy link
Member

qwwdfsad commented May 2, 2023

Could you please merge or rebase the base branch?

@aSemy aSemy force-pushed the feat/apply_bcv branch from 69a8dd5 to 20c5f21 Compare May 2, 2023 17:59
Copy link
Member

@qwwdfsad qwwdfsad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@qwwdfsad qwwdfsad merged commit 14bd77c into Kotlin:bcv-gradle-rework May 4, 2023
@aSemy aSemy deleted the feat/apply_bcv branch May 4, 2023 09:42
qwwdfsad pushed a commit that referenced this pull request Sep 18, 2023
* The ABI shape will be reduced in the future, this is a technical change
qwwdfsad added a commit that referenced this pull request Jan 12, 2024
* Annotate file paths with `@Language("file-reference")` (#126)
* Update to Gradle 8 (#122)
* bump Gradle Plugin Publish Plugin version
* build script updates & improvements
* use Java Toolchains to set the Java version
* use jvm-test-fixtures plugin for functionalTest sources
* update build config, remove redundant Maven publication

* Initial Gradle convention plugins (#123)
* Apply BCV, commit API dump (#131)
* The ABI shape will be reduced in the future, this is a technical change
* java-diff-utils
* Update Gradle to 8.5

---------

Co-authored-by: aSemy <897017+aSemy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants