-
Notifications
You must be signed in to change notification settings - Fork 67
Apply BCV, commit API dump #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
qwwdfsad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks. Will merge after #123 and will sort out ABI eventually, seems like it has a bit too many signatures in public
- bump Gradle Plugin Publish Plugin version - build script updates & improvements - use Java Toolchains to set Java version - use jvm-test-fixtures plugin for functionalTest sources
- create convention plugins for common and java-specific config - add Gradle version catalog - simplify some build config
|
Splitting up the project also helps with organising the public API, the Gradle API dump is quite slim https://github.com/Kotlin/binary-compatibility-validator/pull/124/files#diff-28edfa00a73f55a3939d2d101d50f228ab00b993308b7a0fecffb34f7f73cfae The signature-generator API dump is a little more chunky https://github.com/Kotlin/binary-compatibility-validator/pull/124/files#diff-dd8b72874dcb073e334d55e4b5d0b3850f5f3326a35afea5da50686224ac55f2 |
|
Could you please merge or rebase the base branch? |
qwwdfsad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* The ABI shape will be reduced in the future, this is a technical change
* Annotate file paths with `@Language("file-reference")` (#126)
* Update to Gradle 8 (#122)
* bump Gradle Plugin Publish Plugin version
* build script updates & improvements
* use Java Toolchains to set the Java version
* use jvm-test-fixtures plugin for functionalTest sources
* update build config, remove redundant Maven publication
* Initial Gradle convention plugins (#123)
* Apply BCV, commit API dump (#131)
* The ABI shape will be reduced in the future, this is a technical change
* java-diff-utils
* Update Gradle to 8.5
---------
Co-authored-by: aSemy <897017+aSemy@users.noreply.github.com>
Apply the BCV plugin.
I think we can all agree on why this is helpful :)
This PR depends on