Add deterministic integration scenarios booting real subsystems (ECS / Physics / Render / Network / Scene)#421
Merged
Krilliac merged 4 commits intoApr 9, 2026
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
✅ CI Errors ResolvedAll previously reported errors have been fixed. All builds passing. Last checked: 2026-04-09T05:40:01Z |
Contributor
Code Coverage (GCC + lcov)Per-Subsystem Coverage
Total: 50.7% (18071/35670 lines) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
Tests/Integration/TestSubsystemIntegrationScenarios.cppthat uses a diagnostics-style harness to initializeEngineContext,PhysicsSystem, event bus, and other subsystems and contains four focused scenarios for ECS+Physics, ECS+Rendering, Networking+ECS, and Scene save/load roundtrip with identity checks.ComponentSerializerEntryregistrations for transform/name to ensure snapshot identity round-trips.Tests/CMakeLists.txtto includeIntegration/TestSubsystemIntegrationScenarios.cppin theSparkTeststarget.PhysicsUpdateSystem,PhysicsBodyreadback,Spark::Graphics::ConstantBufferDiffManager,Spark::Net::InstabilitySimulator,ClientPrediction, andSpark::Editor::SceneSnapshotSerializerwith theComponentSerializerRegistry.Testing
clang-format -i Tests/Integration/TestSubsystemIntegrationScenarios.cppsuccessfully to match project formatting rules.cmake --preset linux-gcc-releasewhich configured successfully for the Linux-GCC release preset (tests enabled) without errors.g++ -std=gnu++23 -fsyntax-onlyincluding the engine include paths and entt stub passed for the new source file.cmake --build ... --target SparkTestswhich began building the test target and made substantive progress in this environment, but the full compilation of the entireSparkTeststarget is long-running and did not complete within the interactive session timeout (partial build progress observed).Codex Task