Skip to content

Remove Lua scripting stub and centralize Visual Script node palette metadata - #446

Merged
Krilliac merged 1 commit into
Workingfrom
codex/evaluate-angelscript-vs-unreal-engine-alternatives
Apr 10, 2026
Merged

Remove Lua scripting stub and centralize Visual Script node palette metadata#446
Krilliac merged 1 commit into
Workingfrom
codex/evaluate-angelscript-vs-unreal-engine-alternatives

Conversation

@Krilliac

Copy link
Copy Markdown
Owner

Motivation

  • Remove the standalone Lua scripting stub and references to Lua where the engine does not provide an integrated Lua runtime.
  • Centralize visual script node palette metadata so the editor palette can be driven from a single source of truth in the scripting compiler.
  • Update editor API comments to refer generically to script runtimes instead of enumerating removed/unsupported runtimes.

Description

  • Deleted the Lua scripting engine stub files LuaScriptEngine.cpp and LuaScriptEngine.h and removed all initialization/shutdown and include references to LuaScriptEngine in lifecycle and diagnostics code.
  • Adjusted diagnostic messages to reference the singular scripting engine where appropriate (reworded the diag_scripting description).
  • Added a ScriptNodePaletteEntry struct and palette-building APIs to VisualScriptCompiler (GetNodePalette, GetNodeDisplayName, GetNodeCategory) and implemented a static palette in VisualScriptCompiler.cpp.
  • Refactored VisualScriptPanel to build palette categories at runtime from VisualScriptCompiler::GetNodePalette() and updated UI code to use the new metadata (string usage, ImGui calls, node creation).
  • Minor documentation change in EditorAutomation.h to refer to "script runtimes" and remove the Lua binding example.

Testing

  • Built the engine and editor after the changes and the build completed successfully.
  • Ran the engine unit tests and core diagnostics tests, and they passed without new failures.
  • Manually exercised the visual scripting palette in the editor UI to verify nodes/categories populate and nodes can be added; no runtime errors were observed.

Codex Task

@Krilliac
Krilliac merged commit 3a1db03 into Working Apr 10, 2026
20 of 23 checks passed
@Krilliac
Krilliac deleted the codex/evaluate-angelscript-vs-unreal-engine-alternatives branch April 10, 2026 00:58
@github-actions

Copy link
Copy Markdown
Contributor

Code Coverage (GCC + lcov)

Utils/MemoryMonitor.h                          |85.7%    14| 0.0%  12|    -    0
Utils/MultiISA.h                               |42.9%    14| 0.0%   6|    -    0
Utils/NetworkHealthMonitor.cpp                 | 113%    15| 0.0%   2|    -    0
Utils/NetworkHealthMonitor.h                   |    -     0|    -   0|    -    0
Utils/OpaqueHandle.h                           | 282%    11| 0.0%  15|    -    0
Utils/ProcessLinux.cpp                         |16.5%   182| 0.0%  28|    -    0
Utils/Profiler.cpp                             |14.2%   113| 0.0%  15|    -    0
Utils/Profiler.h                               |36.4%    33| 0.0%  12|    -    0
Utils/RandomEngine.h                           |29.3%    41| 0.0%  12|    -    0
Utils/Result.h                                 | 100%    29| 0.0%  28|    -    0
Utils/RingBuffer.h                             | 108%    59| 0.0%  64|    -    0
Utils/ScopeGuard.h                             | 142%    36| 0.0%  51|    -    0
Utils/ScopedTimer.h                            |25.0%    12| 0.0%   3|    -    0
Utils/Serializer.h                             | 100%    48| 0.0%  42|    -    0
Utils/SparkConsole.cpp                         |28.5%   144| 0.0%  17|    -    0
Utils/SparkConsole.h                           | 100%     2| 0.0%   2|    -    0
Utils/SparkError.h                             |10.9%    55| 0.0%   6|    -    0
Utils/SplinePath.h                             |    -     0|    -   0|    -    0
Utils/StackTrace.h                             |10.8%    74| 0.0%   8|    -    0
Utils/StateMachine.h                           |54.0%    63| 0.0%  32|    -    0
Utils/StringUtils.h                            |18.1%   116| 0.0%  21|    -    0
Utils/Telemetry.h                              |20.7%   135| 0.0%  22|    -    0
Utils/ThreadDebugger.h                         |11.6%   199| 0.0%  23|    -    0
Utils/ThreadSafeQueue.h                        |27.5%    40| 0.0%  11|    -    0
Utils/TimerManager.h                           |19.8%    96| 0.0%  19|    -    0
Utils/UUID.h                                   |43.2%    37| 0.0%  16|    -    0
Utils/Validate.h                               |    -     0|    -   0|    -    0

[/home/runner/work/SparkEngine/SparkEngine/SparkSDK/Include/Spark/]
IEngineContext.h                               |7300%     1| 0.0%   1|    -    0
ServiceInterfaces.h                            | 200%     3| 0.0%   3|    -    0
Version.h                                      |    -     0|    -   0|    -    0
================================================================================
                                         Total:|29.2% 23745| 0.0%  4k|    -    0

Per-Subsystem Coverage

Subsystem Lines Hit Coverage Threshold Status
AI 2776 694 25% 35%
Animation 160 154 96.2% 35%
Audio 0 0 0% 30%
Camera 0 0 0% 40%
Core 2248 1394 62% 40%
ECS 190 114 60% 40%
Editor 6082 1864 30.6% 25%
GameModules 6244 3141 50.3% 30%
Graphics 7202 3795 52.7% 30%
Networking 3379 2247 66.5% 35%
Physics 0 0 0% 35%
Scripting 0 0 0% 30%
Utils 7687 4865 63.3% 60%

Total: 50.8% (18268/35968 lines)

@github-actions

Copy link
Copy Markdown
Contributor

❌ CI Error Report

Failed jobs: windows-vs2022-Release
Errors: 0 | Test failures: 3 | Warnings: 0

Test Failures

Test Jobs
1/1 Test #1: SparkEngineTests .................***Failed 12.43 sec windows-vs2022-Release
[ FAILED ] Integration_NetworkingECS_ReplicationLatencyJitterPredictionReconciliation (718us, 8 assertions) windows-vs2022-Release
0% tests passed, 1 tests failed out of 1 windows-vs2022-Release

Updated: 2026-04-10T01:33:31Z — this comment is updated in-place, not duplicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant