Feat/36/review lane enforces conventions skill list - #50
Merged
Conversation
… reviewer flag violations as comments.
3 tasks
michaelnaughton-euc
left a comment
Collaborator
Author
There was a problem hiding this comment.
Thermo-nuclear code quality review of this PR only. Behavior looks correct and the tests cover both the injected-rules and missing-file paths well. No blockers, but there is a code-judo move here that would delete the new branching instead of adding it — details inline. Summary of findings:
- The review imperative now lives in two homes:
lanes/review.md:6and the header injected byconventions_rules. Implementing lanes keep that imperative in exactly one place (the helper). Pick one home. - The new
lanemode param onconventions_rulesexists only to swap prose. If the imperative sentences move into the lane playbooks, the helper becomes lane-agnostic data emission and the param, the branch, and the duplicated "This repo enables these skills; invoke each one that applies" line all disappear. - Minor:
run_reviewin tests copiesrun_lane's env boilerplate; theRULES+CONVENTIONSassembly is now duplicated verbatim between thefeature|bug|docsandreviewcase arms.
Also noting for the record: factory.sh was already over 1000 lines before this PR (1025 → 1035), so this isn't a threshold crossing, but the duplicated rules-assembly in the case arms is the kind of growth that will keep pushing it up.
…nto the lane playbooks.
michaelnaughton-euc
marked this pull request as ready for review
August 27, 2026 05:07
Kripu77
approved these changes
Aug 27, 2026
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The review lane now gets the .factory/conventions skill list in its rules whenever the file exists in the target checkout, phrased for reviewing: invoke each listed skill and flag every violation as a review comment. lanes/review.md carries the matching instruction, and tests/conventions.sh covers both the injected rules and the missing-file case. Closes #36.