Add webhooks test - #141
Merged
Merged
Conversation
jakurban
reviewed
Nov 7, 2022
pehala
reviewed
Nov 7, 2022
mkudlej
force-pushed
the
raw_http_webhook
branch
from
November 8, 2022 15:19
23f9982 to
b84916c
Compare
pehala
reviewed
Nov 8, 2022
mkudlej
force-pushed
the
raw_http_webhook
branch
from
November 16, 2022 13:41
b84916c to
125d2b2
Compare
mkudlej
force-pushed
the
raw_http_webhook
branch
2 times, most recently
from
November 24, 2022 10:56
146f40b to
6f70598
Compare
pehala
reviewed
Nov 24, 2022
mkudlej
force-pushed
the
raw_http_webhook
branch
from
November 28, 2022 15:55
6f70598 to
d2fb4bc
Compare
pehala
reviewed
Nov 29, 2022
mkudlej
force-pushed
the
raw_http_webhook
branch
2 times, most recently
from
November 29, 2022 15:58
69d5df8 to
d45e5fa
Compare
pehala
reviewed
Nov 30, 2022
pehala
left a comment
pehala
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the changes! It is much better now!
mkudlej
force-pushed
the
raw_http_webhook
branch
from
November 30, 2022 10:46
d45e5fa to
fa6f098
Compare
pehala
previously approved these changes
Nov 30, 2022
|
@mkudlej PR looks good, but I would appreciate a short description for |
Author
|
@jsmolar Is it better? |
mkudlej
force-pushed
the
raw_http_webhook
branch
from
November 30, 2022 13:24
fa6f098 to
8eebc76
Compare
jsmolar
approved these changes
Nov 30, 2022
pehala
approved these changes
Nov 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds testcase for testing k8s Dynamic Admission Control webhooks, see https://kubernetes.io/docs/reference/access-authn-authz/extensible-admission-controllers/ which are used for calling Authorino service for authenticating of Ingress object creation.