Fix/refactor authorino metadata tests#666
Merged
averevki merged 1 commit intoKuadrant:mainfrom Apr 29, 2025
Merged
Conversation
Signed-off-by: averevki <sandyverevkin@gmail.com>
averevki
added
bug
averevki
changed the title
trepel
reviewed
Apr 29, 2025
trepel
reviewed
Apr 29, 2025
trepel
reviewed
Apr 29, 2025
trepel
approved these changes
Apr 29, 2025
Contributor
trepel
left a comment
trepel
left a comment
There was a problem hiding this comment.
Very nice! I have a few questions (mosty to educate myself so no blockers for merging) but the code looks good to me. Also the tests passed for me.
LGTM
azgabur
approved these changes
Apr 29, 2025
Member
azgabur
left a comment
azgabur
left a comment
There was a problem hiding this comment.
Extra test cases and nice weakget fix 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes aimed to improve nightlies execution of cached authorino tests.
Verification steps