Fix plain identity test#674
Merged
averevki merged 1 commit intoKuadrant:mainfrom May 6, 2025
Merged
Conversation
Signed-off-by: averevki <sandyverevkin@gmail.com>
emmaaroche
approved these changes
May 6, 2025
Contributor
emmaaroche
left a comment
emmaaroche
left a comment
There was a problem hiding this comment.
Left a comment under one line just to better understand the logic, mainly from a learning perspective. Since all tests passed, I've approved the changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix plain identity test. This test broke after I fixed weakget usage inside the extract_response utility this test uses #666.
Fix explanation: #666 (comment)
Verification steps
pytest testsuite/tests/singlecluster/authorino/identity/plain/test_plain_identity.py [--standalone]Additional context
P.S. I think this test only mildly covers whether the plain identity works as intended, and we need a more real-world scenario to be tested with the plain identity (made an issue for now #673)