Skip to content

refactor(settings): split agents section helpers - #823

Merged
XingYu-Zhong merged 1 commit into
KunAgent:developfrom
luoye520ww:codex/split-agents-settings
Jul 9, 2026
Merged

refactor(settings): split agents section helpers#823
XingYu-Zhong merged 1 commit into
KunAgent:developfrom
luoye520ww:codex/split-agents-settings

Conversation

@luoye520ww

Copy link
Copy Markdown
Collaborator

Summary

  • Splits pure helper logic out of the large Agents settings section into settings-section-agents-utils.
  • Covers MCP permission summaries, Skill permission summaries, model context labels, compact list labels, and token economy savings loading from the new helper module.
  • Keeps the settings UI and state update paths unchanged.

Why

This is a small frontend performance/maintainability split. settings-section-agents.tsx was carrying pure parsing and summary logic inline, which made the lazy-loaded settings chunk harder to review and evolve. This PR moves that logic behind targeted tests without introducing a new runtime path.

Tests

  • npm.cmd test -- src/renderer/src/components/settings-section-agents-utils.test.ts src/renderer/src/components/settings-section-agents.test.ts
  • npm.cmd run typecheck
  • npm.cmd run build
  • git diff --check kunagent/develop...HEAD

Note: the build still reports the existing MessageTimeline static/dynamic import warning on current develop. That warning is addressed separately by #820 and is not introduced by this PR.

@XingYu-Zhong XingYu-Zhong left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed via Codex triage; approved for merge.

@XingYu-Zhong
XingYu-Zhong merged commit c758d60 into KunAgent:develop Jul 9, 2026
@luoye520ww
luoye520ww deleted the codex/split-agents-settings branch July 13, 2026 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants