fix(permissions): scope external path approval per call#978
Merged
Conversation
XingYu-Zhong
force-pushed
the
codex/replace-887-external-path-approval
branch
from
July 18, 2026 16:53
4c7982b to
523f320
Compare
XingYu-Zhong
force-pushed
the
codex/replace-887-external-path-approval
branch
from
July 19, 2026 05:00
523f320 to
6762769
Compare
XingYu-Zhong
marked this pull request as ready for review
July 19, 2026 05:01
There was a problem hiding this comment.
PR checks failed. Please fix the failing CI jobs before merging.
Failed jobs:
- Ad-hoc macOS packaged validation (PR)
Run details: https://github.com/KunAgent/Kun/actions/runs/29674204821
XingYu-Zhong
dismissed
github-actions[bot]’s stale review
July 19, 2026 06:04
Transient macOS packaged-extension guest-target timeout; the failed job was rerun in isolation and the complete workflow passed on the same PR head.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
developbranch.Changes
writeandedittools into exact per-call external-path approval.openatprimitive.This protects the approval workflow from path redirection; it is not an OS-level lock against a hostile same-user process racing the final system call.
Tests
git diff --check.Original contribution and problem analysis: @luoye520ww in #887.
Replaces #887.