InstanceID deprecation in Unity 6.5b

[jasonpanosso]

related to #462

With InstanceID being deprecated in Unity 6.5, there are a few spots in the code that will trigger compiler errors(CS0169) when attempting to use Animancer in Unity 6.5.

Currently, there are a few spots in the code that trigger CS0168 obsolete warnings for usage of InstanceID in 6.4 stable, or conversion of an int(instanceID) to entity id/game object, these are:

Packages\com.kybernetik.animancer\Editor\Serialization\SerializedComponentDataEditorWindow.cs(46,68): warning CS0618: 'EntityId.implicit operator EntityId(int)' is obsolete: 'EntityId will not be representable by an int in the future. This casting operator will be removed in a future version.'

Packages\com.kybernetik.animancer\Editor\Transition Libraries\TransitionLibraryWindow.cs(40,56): warning CS0618: 'EntityId.implicit operator EntityId(int)' is obsolete: 'EntityId will not be representable by an int in the future. This casting operator will be removed in a future version.'

Packages\com.kybernetik.animancer\Editor\Serialization\SerializedComponentDataEditorWindow.cs(73,46): warning CS0618: 'Object.GetInstanceID()' is obsolete: 'GetInstanceID is deprecated. Use GetEntityId instead. This will be removed in a future version.'

[jasonpanosso]

apologies, this should be labeled as a feature request for new version support

[KybernetikGames]

I'll have a look into this. It sounds like something they're doing intentionally rather than a bug that might get fixed before the official release so it's probably worth checking out.

Is it blocking your work or is it an obvious fix?

[jasonpanosso]

I'll have a look into this. It sounds like something they're doing intentionally rather than a bug that might get fixed before the official release so it's probably worth checking out.

Is it blocking your work or is it an obvious fix?

I was able to monkey patch the 3 spots in the code to use EntityId instead of InstanceId, not blocked but it would be a nice feature for when 6.5 is promoted to stable

[KybernetikGames]

Animancer v8.4.0 is now available with these issues fixed.