FIX: Fix initialization#2
Merged
Merged
Conversation
Member
Author
|
Hold off on merging for a sec, need to fix a test. |
Member
Author
|
Okay, should be good to merge if you want to take a look. You could also just merge, and make corrections in your own branch as you go. Feel free to open a PR as soon as you want to get feedback. Throw a "WIP:" in front of it, like I should have, if you don't want it merged after I review. :) |
drammock
added a commit
that referenced
this pull request
Jul 23, 2013
FIX: Fix initialization (looks good)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now the code will install, and the example runs.