fix(web): hide empty composer context strip in simple mode - #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In simple mode with a git-backed project, the composer rendered a second, empty box below the input: the composer context strip was mounted (because the project is a git repo) but showed nothing (git controls hidden, no environment indicator), so its empty drawer outline rendered as a detached second box above the Send button.
Fix
Gate the context strip on showGitControls instead of isGitRepo in shouldShowComposerContextStrip (BranchToolbar.logic.ts + both ChatView.tsx call sites). In simple mode showGitControls is false, so the strip no longer mounts when its only potential content is hidden git controls; non-simple mode is unchanged. Tests in BranchToolbar.logic.test.ts updated (70 passing); lint clean. Visually confirmed by the user on the isolated dev server (double box gone).
Done by opencode/big-pickle (OpenCode harness).