ladder: rung 3 -- polls - #91
Draft
Yaraslaut wants to merge 1 commit into
Draft
Conversation
Split out of application-ladder (originally bundled with pastebin/ bookmarks and the shared foundation in #41) into its own PR against the rung-0 foundation (#88). Includes the pool-migration fix folded in during review of the combined branch: - PollModel (this ladder's BRIDGE_MODEL_KEY-shared/keyed model) acquires connections from Lightweight::GlobalDataMapperPool() per execute() call rather than holding one for its own lifetime (WithMapper removed); applyVotes() (private helper, called from within execute() bodies that don't need to share its connection) makes its own independent acquisition. Verified standalone against the ladder-foundation base: configures and builds with -DMORPH_LADDER_RUNGS=polls and no other rung present. Full suite passes: 557 assertions in 68 test cases (SQLite default). Spec-citation and test-type-name lints clean. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Rung 3 of the application ladder: polls, anchored on Rallly. Split out of #41 into its own PR, targeting #88's
ladder-foundationbranch since it depends on the shared testkit/CMake infra there.Draft until #88 merges — retarget to
masterand un-draft once it does.Contents
examples/polls/in full:PollModel(this ladder'sBRIDGE_MODEL_KEY-shared/keyed model), DTOs, entity, schema migration, authorizer, server, Qt/QML GUI, and tests — 40 files.Includes a fix folded in during review of the combined branch:
PollModelacquires connections fromLightweight::GlobalDataMapperPool()perexecute()call rather than holding one for its own lifetime (WithMapperremoved);applyVotes()(a private helper called from withinexecute()bodies that don't need to share its connection) makes its own independent acquisition.Verification
Configured and built standalone against the
ladder-foundationbase with-DMORPH_LADDER_RUNGS=polls(no other rung present). Full suite passes: 557 assertions in 68 test cases (SQLite default). Spec-citation and test-type-name lints clean.