Skip to content

add groupId #2083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
timburke-hackit merged 2 commits into from
Jan 24, 2025
Merged

add groupId #2083

timburke-hackit merged 2 commits into from
Jan 24, 2025

Conversation

@timburke-hackit
Copy link
Contributor

@timburke-hackit timburke-hackit commented Jan 24, 2025 •
edited
Loading

Adds a missing groupId config for the assembly plugin.

Now does mvn clean package to ensure the target directory is empty before building the jar.

The ETL workflow has run OK including the step this relates to. Commit that triggered this run is squashed into add groupId 9ed682b

image

@timburke-hackit
add groupId
9ed682b 
trigger core workflow

Revert "trigger core workflow"

This reverts commit 30becbc.

trigger etl workflow

fix typo

Revert "trigger etl workflow"

This reverts commit 786bbf3.
@timburke-hackit
do clean package
c57594c
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 24, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@timburke-hackit timburke-hackit marked this pull request as ready for review January 24, 2025 16:54
Tian-2017
Tian-2017 approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@Tian-2017 Tian-2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing it

@timburke-hackit timburke-hackit merged commit 7c03099 into main Jan 24, 2025
5 checks passed
@timburke-hackit timburke-hackit deleted the maven-config branch January 24, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tian-2017 Tian-2017 Tian-2017 approved these changes

@LBHSBALLEY LBHSBALLEY Awaiting requested review from LBHSBALLEY

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@timburke-hackit @Tian-2017