Skip to content

Conversation

@ibrahimhroob
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

This Pull Request (PR) aims to improve the path fluidity and efficiency for kinematically constrained robots (like Ackermann/car-like vehicles) when navigating through a sequence of waypoints (ComputePathThroughPoses).

The core issue this PR addresses is the robot stopping and unnecessarily rotating at intermediate waypoints because the underlying SmacPlannerHybrid (which uses kinematic models like Reeds-Shepp or Dubins) strictly enforces the orientation of every pose it receives.

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes.

[optional] Are there any post deployment tasks we need to perform?

@ibrahimhroob ibrahimhroob self-assigned this Nov 27, 2025
Copy link
Member

@marc-hanheide marc-hanheide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good and sensible. It may be a good discussion if this shouldn't actually be the default... or rather be the default in the actual goal. For instance, rather than prescribing this behaviour in the configuration in general we may want to make it part of the action we call? There may be use case where the previous behaviour is useful and wanted. E.g. for in row nav (e.g. for data gathering use cases on want to ensure a specific pose is reached).

@ibrahimhroob ibrahimhroob merged commit aeebdc2 into aoc Nov 27, 2025
@ibrahimhroob ibrahimhroob deleted the allow_intermediate_orientation_override branch November 27, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants