feat(auth): makes SSO portable via env variables#15
Merged
Conversation
Signed-off-by: Lorenzo Setale <lorenzo.setale@LEGO.com>
Signed-off-by: Lorenzo Setale <lorenzo.setale@LEGO.com>
Signed-off-by: Lorenzo Setale <lorenzo.setale@LEGO.com>
Signed-off-by: Lorenzo Setale <lorenzo.setale@LEGO.com>
Signed-off-by: Lorenzo Setale <lorenzo.setale@LEGO.com>
Signed-off-by: Lorenzo Setale <lorenzo.setale@LEGO.com>
… it will hide it Signed-off-by: Lorenzo Setale <lorenzo.setale@LEGO.com>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Signed-off-by: Lorenzo Setale <lorenzo.setale@LEGO.com>
PaulFarver
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Oh new thing from the fabulab:
BUN_PUBLIC_*env (I struggled to get them done in bun :( )BTW, I am not a huge fan of /api/env as it could expose values. I have set it up this way, as these env are NOT secrets, but we want to allow people to customize and provide different prometheus endpoints, OIDC config, based on their needs, rather than hard coding the values.
Note: This forces us to run the server with the frontend, those cannot be decoupled because of /api/web 😅