feat(output): set default variables and allow features to ovewrite them if needed#30
Merged
Merged
Conversation
…le sources set them Signed-off-by: Lorenzo Setale <lorenzo.setale@LEGO.com>
Signed-off-by: Lorenzo Setale <lorenzo.setale@LEGO.com>
…esent Signed-off-by: Lorenzo Setale <lorenzo.setale@LEGO.com>
Signed-off-by: Lorenzo Setale <lorenzo.setale@LEGO.com>
… insight and name is correct Signed-off-by: Lorenzo Setale <lorenzo.setale@LEGO.com>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Signed-off-by: Lorenzo Setale <lorenzo.setale@LEGO.com>
koalalorenzo
changed the title
PaulFarver
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we use Novus in our internal LEGO way, users will get metrics and logs from Novus datasource... so why not set it for the users? Here we go!
So if no prom or loki datasources are added by features, it will add them to generic grafana cloud values, otherwise it will use them :D