Pass sample_idx through to the custom agent function#61
Closed
DavidBellamy wants to merge 2 commits into
Closed
Conversation
agentic_tool_call.generate forwards only `metadata` to the custom agent function, so a sample's `index` never reaches it. Harbor's dashboard hooks now require `request.sample_idx` (LLM360/RL360 radixark#432 replaced Harbor's internal trial counter with `request.sample_idx`), so every agentic trial fails with "sample_idx is required". Lift `sample.index` into the metadata passed to the agent, matching the existing `metadata = {**metadata, ...}` augmentations (max_seq_len, session_server_id).
|
Addressed by #58? |
Collaborator
Author
|
Targets main instead of prod |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
agentic_tool_call.generateforwards onlymetadatato the custom agentfunction, so a sample's
indexnever reaches it. Harbor's dashboard hooks nowrequire
request.sample_idx(LLM360/RL360#432 replaced Harbor's internal trialcounter with
request.sample_idx), so every agentic trial fails with"sample_idx is required".
This lifts
sample.indexinto that metadata, matching the existingmetadata = {**metadata, ...}lines (max_seq_len, session_server_id).