clang-tidy: Apply modernize-loop-convert everywhere - #6481
Merged
Conversation
DomClark
reviewed
Aug 9, 2022
DomClark
reviewed
Aug 10, 2022
…ument.cpp Co-authored-by: Dominic Clark <mrdomclark@gmail.com>
…Sfxr.cpp Co-authored-by: Dominic Clark <mrdomclark@gmail.com>
…fxr.cpp Co-authored-by: Dominic Clark <mrdomclark@gmail.com>
…ithin plugins/Sfxr/Sfxr.cpp Co-authored-by: Dominic Clark <mrdomclark@gmail.com>
Co-authored-by: Dominic Clark <mrdomclark@gmail.com>
DomClark
approved these changes
Aug 12, 2022
In the future, if an effort was made to remove unnecessary heap allocations (which is the reason why most classes are a pointer anyways), having "for (auto ..." would make copies. Plus, it will make things even more difficult because "for (auto ..." would still compile, causing a hard to track performance hit if it isn't replaced with "for (auto& ..." right now.
allejok96
approved these changes
Aug 27, 2022
allejok96
left a comment
allejok96
left a comment
Contributor
There was a problem hiding this comment.
Everything looks good, just have some optional suggestions.
Co-authored-by: allejok96 <allejok96@gmail.com>
Contributor
|
I originally considered reviewing this, but it already has 2 reviews, which should be enough. @sakertooth Can you please fix the merge conflicts? |
Contributor
Author
Will do. |
sakertooth
added a commit
to sakertooth/lmms
that referenced
this pull request
May 30, 2023
Co-authored-by: allejok96 <allejok96@gmail.com> Co-authored-by: Dominic Clark <mrdomclark@gmail.com>
sakertooth
added a commit
to sakertooth/lmms
that referenced
this pull request
May 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extremely useful here in my opinion.
This clang-tidy check transforms for loops into their range-based loop equivalent where applicable. This in particular was ran using the
MinConfidenceoption set to reasonable, which is the default.