Switch from JSON::XS::VersionOneAndTwo to JSON::XS - #1619
Merged
michaelherger merged 2 commits intoJul 26, 2026
Conversation
mavit
force-pushed
the
json-xs-versiononeandtwo
branch
from
July 22, 2026 13:57
1e7445f to
18081c2
Compare
The purpose of `JSON::XS::VersionOneAndTwo` is to provide compatibility with the API of versions of `JSON::XS` earlier than 2.01 (released 2007). However, we know we have at least version 2.3 of `JSON::XS`, since that’s what we specify in `modules.conf`. I would like to go further and remove `JSON::XS::VersionOneAndTwo` from `modules.conf` and the `CPAN/` directory, but I hesitate, because it seems like something that third-party plugins might expect to be available. Signed-off-by: Peter Oliver <git@mavit.org.uk>
mavit
force-pushed
the
json-xs-versiononeandtwo
branch
from
July 22, 2026 13:57
18081c2 to
5e99a54
Compare
Member
|
Yeah, 3rd party plugins might be a problem. I've stuck to using that module, too. Will change on my side to lead by example 😁. |
michaelherger
requested changes
Jul 26, 2026
michaelherger
left a comment
michaelherger
left a comment
Member
There was a problem hiding this comment.
Could you please remove the unused imports? Thanks!
As calculated by `perlimports`. Signed-off-by: Peter Oliver <git@mavit.org.uk>
mavit
force-pushed
the
json-xs-versiononeandtwo
branch
from
July 26, 2026 14:04
d98a1da to
3d85b10
Compare
Member
|
Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The purpose of
JSON::XS::VersionOneAndTwois to provide compatibility with the API of versions ofJSON::XSearlier than 2.01 (released 2007). However, we know we have at least version 2.3 ofJSON::XS, since that’s what we specify inmodules.conf.I would like to go further and remove
JSON::XS::VersionOneAndTwofrommodules.confand theCPAN/directory, but I hesitate, because it seems like something that third-party plugins might expect to be available.Relates to #138.