Add dotnet-trace.exe and dotnet-counters.exe - #522
Conversation
There was a problem hiding this comment.
Hi @ivancabrera02 , thank you for opening this PR.
The binaries are not present on Windows 11 by default. Your entries point to a folder in Program Filesbut your screenshot showssystem32. Could you please let me know which .NET installer you used?- Additionally, you put your submissions in the
OSBinariesfolder, which because of the above observation should beOtherMSBinaries. - The labels you define do not exist and are not consistent with other contributions, please remove them and add
Execute: EXE. - The format you used for Operating Systems is not consistent with other entries, please update
- Instead of
calc.exeplease use the following placeholder:{PATH:.exe} - Please fix the error generated by GitHub actions (
Executionshould beExecute). - MITRE ATT&CK ID should be
T1127on both
Changes per reviewer request:
- Move files from OSBinaries/ to OtherMSBinaries/ (not default Windows binaries)
- Fix Category: Execution -> Execute (dotnet-trace.yml)
- Fix Tags: remove custom labels, add Execute: EXE
- Fix OperatingSystem format: Windows 10, Windows 11
- Replace calc.exe with {PATH:.exe} placeholder
- Fix MitreID: T1059 -> T1127 on both entries
- Fix Full_Path to correct install location (%USERPROFILE%\.dotnet\tools\)
- Add Handle to Acknowledgement
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Thanks for the detailed review @wietze! All points addressed in the latest commit:
|
Both binaries included in .NET can run child processes.