Skip to content

agentic: artifact_create, artifact_edit tool - #2

Draft
LPFchan wants to merge 2 commits into
agentic-question-commonfrom
agentic-artifacts
Draft

agentic: artifact_create, artifact_edit tool#2
LPFchan wants to merge 2 commits into
agentic-question-commonfrom
agentic-artifacts

Conversation

@LPFchan

@LPFchan LPFchan commented May 29, 2026

Copy link
Copy Markdown
Owner

split into three PRs per ggml-org#23831 (3/3)
adds artifact_create and artifact_edit tool to llama.cpp's list of built-in tools.
stacked on ggml-org#23848 + #(PR2) for shared tool execution layer.
server: artifact creation/editing, attachments in tool results, metadata handling
ui: artifact blocks in chat when one of two tools are called, split view side panel for presentation

tests:

  • git diff --check
  • .venv/bin/python -m pytest tools/server/tests/unit/test_server_tools.py
  • ./node_modules/.bin/vitest --config vite.config.ts --project=unit tests/unit/agentic-builtin-results.test.ts
  • ./node_modules/.bin/vitest --config vite.config.ts --project=unit tests/unit/tool-result-attachments.test.ts tests/unit/agentic-builtin-results.test.ts

@LPFchan
LPFchan force-pushed the agentic-artifacts branch from 08cd3cf to 378e5c1 Compare May 29, 2026 02:53
@LPFchan
LPFchan force-pushed the agentic-todowrite branch from 570e8b8 to bcf731d Compare May 29, 2026 02:53
LPFchan added 2 commits July 22, 2026 21:55
Assisted-by: Codex
Completes the artifact built-in tool UI on top of F1+F2:
- ChatMessageToolCallBlockArtifactCreate/Edit: render artifacts from
  section.toolResultExtras with streamed-metadata/error parsing and clickable
  preview cards.
- ChatScreenArtifactPane: TEXT/Markdown/image/PDF/audio/video previews with
  download + close.
- ChatScreen: latest-artifact auto-presentation with dismissal tracking;
  desktop half-width sticky pane, mobile full-screen; agentic-artifact-open
  event wiring.
- agentic-artifact.ts: attachment filtering, stable identity, safe metadata parse.

This is the F2 + artifact UI content for PR3 (stacked on F1).

Verification: full 'npm run check' unavailable offline (npm ci EAI_AGAIN);
scoped svelte-check = 0 errors/0 warnings, all files parse/transpile, Prettier
+ git diff --check pass. Re-run 'npm run check' on a networked checkout before
pushing PR3.
@LPFchan
LPFchan force-pushed the agentic-todowrite branch from bcf731d to 89b44a3 Compare July 22, 2026 12:56
@LPFchan
LPFchan force-pushed the agentic-artifacts branch from 378e5c1 to 3f4e8f7 Compare July 22, 2026 12:56
@LPFchan
LPFchan changed the base branch from agentic-todowrite to agentic-question-common July 22, 2026 12:56
@github-actions github-actions Bot added documentation Improvements or additions to documentation server/ui server labels Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation server/ui server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant