Skip to content

Tell Agents that E2E tests manage their own lifecycle#187

Merged
ejfine merged 2 commits into
mainfrom
e2e
Jul 24, 2026
Merged

Tell Agents that E2E tests manage their own lifecycle#187
ejfine merged 2 commits into
mainfrom
e2e

Conversation

@ejfine

@ejfine ejfine commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Why is this change necessary?

Claude is constantly trying to spin up services before running E2E tests

How does this change address the issue?

Updates AGENTS.md

Summary by CodeRabbit

  • Documentation
    • Clarified that end-to-end tests automatically start and stop required application services, eliminating manual setup.
  • Compatibility
    • Updated the minimum supported Faker version to 40.35.0 to ensure consistent template behavior.

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Updates E2E testing guidance to use harness-managed services and raises the minimum python_faker_version constraint from >=40.28.1 to >=40.35.0.

Changes

Template maintenance

Layer / File(s) Summary
E2E service lifecycle guidance
AGENTS.md
Adds guidance that E2E tests should not manually start services because session fixtures manage service startup and teardown.
Python Faker version constraint
extensions/context.py
Raises the python_faker_version minimum requirement to >=40.35.0.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: zendern, idonaldson

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description only fills two template sections and omits link, side effects, testing, and other details. Add the missing template sections, especially issue/thread link, side effects, how it was tested, and any other relevant notes.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly matches the main change: updating AGENTS guidance so E2E tests manage their own lifecycle.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@extensions/context.py`:
- Line 66: Update the python_faker_version assignment in the context setup to
use a Faker version currently published on PyPI, such as >=40.32.0, or match the
existing lockfile version; do not require >=40.35.0 until that release exists.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 0fafc5ea-13ff-470d-8c4c-c570b5aef295

📥 Commits

Reviewing files that changed from the base of the PR and between f41390c and 5566160.

📒 Files selected for processing (2)
  • AGENTS.md
  • extensions/context.py

Comment thread extensions/context.py
@ejfine
ejfine marked this pull request as ready for review July 24, 2026 15:07
@ejfine
ejfine requested a review from zendern July 24, 2026 15:07
@ejfine
ejfine merged commit ed7c6e6 into main Jul 24, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants