Update PurgeArtifacts task for configuration cache and more complete clean up - #233
Merged
Conversation
…e and to work with input files so archived projects can be kept up to date
labkey-tchad
approved these changes
Aug 1, 2025
labkey-adam
approved these changes
Aug 2, 2025
|
|
||
| commonsIoVersion=2.18.0 | ||
| commonsLang3Version=3.17.0 | ||
| commonsLang3Version=3.18.0 |
Contributor
There was a problem hiding this comment.
Consider updating all the other dependencies... I believe Commons IO, Commons Text, HttpClient, HttpCore, Jackson, and Json all have newer versions.
Contributor
Author
There was a problem hiding this comment.
Done. Everything except artifactoryPluginVersion, where the latest version requires Gradle 9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
The
PurgeArtifactstask was walking through the set of gradle projects to find what needed to be purged, which is fine until we archive repositories so they are no longer needed in a typical enlistment. This implementation, because it usedproject.allprojects, is also not compatible with Gradle's configuration cache. This PR changes the implementation to read the list of projects from a file and also will read a list of versions from a file to make it easier to purge several versions.Related Pull Requests
Changes
PurgeArtifactswith more configuration cache-friendly properties