Emit CommonJS for global bundle to restore LABKEY overrides#221
Merged
Conversation
This was referenced Jul 10, 2026
labkey-klum
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Setting the compile target to
ES2023flipped the global browser bundles from CommonJS to ES module emit, which broke legacy runtime overrides of theLABKEY.*namespaces. ESM exports are read-only getters that webpack also inlines via scope hoisting, so the namespaces can no longer be patched. Sincemodule/moduleResolutionare build-time-only and independent of the language target, this restores CommonJS emit for the global bundles while keeping theES2023target.Related Pull Requests
Changes
nodenext) and disable module concatenation in global bundlesLABKEY.*namespaces directly from the API exports