Issue 51606: labkey.webdav.downloadFolder to match file path prefix to the href values returned in listDir, which are URL encoded paths

[cnathe]

Rationale

https://www.labkey.org/home/Developer/issues/issues-details.view?issueId=51606

Related Pull Requests

• Issue 50861: Pass around properly encoded WebDav URLs platform#5961

Changes

• encode folderPath and remoteFilePath in labkey.webdav.doDownloadFolder
• use the "href" instead of "id" for comparing paths for results of labkey.webdav.listDir

[labkey-jeckels]

This looks good to me.

It seems like the important thing here is to create a properly encoded URL, and not to exactly match the way against a URL created elsewhere. If we need to match exactly, we need to be mindful of exactly which characters get encoded and how. See PageFlowUtil encode() vs encodeURIComponent().

[cnathe]

Rlabkey v3.4.1 has been submitted to CRAN and accepted.