Additional validation for assay run configurations#118
Merged
labkey-klum merged 3 commits intodevelopfrom Jul 22, 2025
Merged
Conversation
cnathe
approved these changes
Jul 22, 2025
|
|
||
| ## validate run properties if provided | ||
| if (!is.null(run$properties) && !is.list(run$properties)) | ||
| stop (paste("run properties must be a list of key value pairs.")) |
Contributor
There was a problem hiding this comment.
minor: the first param is "config" so should this say "config properties must be a list of key value pairs."?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
related issue
This change validates the shape of the run properties that might be passed into the
experiment.createRunfunction so we don't fail when we try to parse the JSON posted data on the server. The repro is to run this or similar code:The other client APIs don't seem to have this problem due to the presence of more composed types versus allowing free form JSON text.
With this change, if the properties object is not valid, we will throw the following error (list is the R data type that serializes to a JSON object):