Formsy: validation messages update on prop changes - #2051
Open
labkey-nicka wants to merge 3 commits into
Open
Conversation
labkey-nicka
force-pushed
the
fb_associate
branch
from
August 7, 2026 00:11
69cd85b to
5fe6616
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This remedies a render lifecycle problem in our Formsy implementation. Formerly, when a validation component was passed, prop changes on that component would not necessarily result in a re-render causing stale rendering. Now validation component props are checked for changes upon component update.
Related Pull Requests
Changes
isShallowSamecheck and compare validation components on component updateuseDataChangeCommentsRequiredto furnish loading state