Issue 52886: SourcesAuditEvent update event newRecordMap diff missing value for an updated field with a long name - #6858
Merged
Merged
Conversation
…ner filter for lookups is viable
…instead of db query (again) and set proper container filter when copying properties for a lookup instead of setting for the full query table.
…oss-type/cross-container imports.
| // Issue 52886: Use queryTable here, not raw database table, so the rows are from the user schema with names | ||
| // as expected to match row inserts and other querySchema data | ||
| SimpleFilter filter = new SimpleFilter(); | ||
| if (null != rowid) |
Contributor
There was a problem hiding this comment.
nit: Rename rowid to rowId.
| * @param container The container that is the target of the import or update | ||
| * @param user The user doing the action | ||
| */ | ||
| public static void setContainerFilterForImport(QueryDefinition qDef, Container container, User user) |
Contributor
There was a problem hiding this comment.
I can understand why this is in ExpDataIterators but it seems like something we'd want to move next to the other container filter operations on QueryService at some point.
labkey-nicka
approved these changes
Jul 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Issue 52886: For data classes, the
_selectRowmethod had been doing a query against the database table instead of the user schema table. For long field names (at least), the db field names and query schema field names do not match. This results in the diff check for auditing to not see a difference for such fields. The "fix" for Issue 52504 was also somewhat misguided because it placed the lookup container filter too globally. Instead we want to set the proper container filter on the lookup columns themselves.Related Pull Requests
Changes
AuditHandler.getOldAndNewRecordForMergeto not do detailed audit logging for multivalued fields that updated valuesExpDataClassDataTableimpl._selectRowmethod to use the user schema table not the database table