GitHub Issue #1298: Allow Workflow Task and Comments assay run field to be hidden during assay import from apps - #7874
Merged
Merged
Conversation
…roductFeatureEnabled for ProductFeature.Workflow
labkey-nicka
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
https://github.com/LabKey/internal-issues/issues/1298
Let the assay-import Run Details panel hide the Comments and Workflow Task fields based on server-provided column metadata (shownInInsertView) rather than a client-side workflow flag. The server (ExpRunTableImpl) now sets the WorkflowTask column's shownIn*View to false only when ProductFeature.Workflow is disabled, and the client stops force-overriding those flags in queryMetadata.ts, instead reading them off the fetched QueryInfo.
Related Pull Requests
Changes