Skip to content

GitHub Issue #1298: Allow Workflow Task and Comments assay run field to be hidden during assay import from apps - #7874

Merged
cnathe merged 3 commits into
developfrom
fb_assayRunProps1298
Jul 24, 2026
Merged

GitHub Issue #1298: Allow Workflow Task and Comments assay run field to be hidden during assay import from apps#7874
cnathe merged 3 commits into
developfrom
fb_assayRunProps1298

Conversation

@cnathe

@cnathe cnathe commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Rationale

https://github.com/LabKey/internal-issues/issues/1298

Let the assay-import Run Details panel hide the Comments and Workflow Task fields based on server-provided column metadata (shownInInsertView) rather than a client-side workflow flag. The server (ExpRunTableImpl) now sets the WorkflowTask column's shownIn*View to false only when ProductFeature.Workflow is disabled, and the client stops force-overriding those flags in queryMetadata.ts, instead reading them off the fetched QueryInfo.

Related Pull Requests

Changes

  • set default WorkflowTask field properties on server side based on isProductFeatureEnabled for ProductFeature.Workflow

…roductFeatureEnabled for ProductFeature.Workflow
@cnathe cnathe self-assigned this Jul 22, 2026
@cnathe
cnathe merged commit eda5c9f into develop Jul 24, 2026
7 of 8 checks passed
@cnathe
cnathe deleted the fb_assayRunProps1298 branch July 24, 2026 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants